prevent panic on paraformer engine init failure#36
Open
AdityaShome wants to merge 1 commit intomofa-org:mainfrom
Open
prevent panic on paraformer engine init failure#36AdityaShome wants to merge 1 commit intomofa-org:mainfrom
AdityaShome wants to merge 1 commit intomofa-org:mainfrom
Conversation
…tead of unwrapping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a critical bug where the
dora-funasr-mlxnode would panic and silently crash the entire voice chat dataflow if the Paraformer ASR engine failed to initialize (e.g., due to missing MLX models or out-of-memory errors).Because Dora does not automatically restart nodes when they panic, this would cause the UI to remain stuck in the "running" state without any transcription ever arriving.
Fixes: #34
Changes Made
unwrap()on the lazily initializedengineatnode-hub/dora-funasr-mlx/src/main.rs:103with a safematchblock.log::error!message and asend_log()Dora event to inform the user.continueto safely skip the audio frame if the engine is unavailable, keeping the node alive so it doesn't crash the dataflow.Testing
None.cargo fmtpassed cleanly.