feat: fixes mofa-asr manifest mismatch and adds baseline dora_integration tests#67
Open
Ishita-190 wants to merge 6 commits intomofa-org:mainfrom
Open
feat: fixes mofa-asr manifest mismatch and adds baseline dora_integration tests#67Ishita-190 wants to merge 6 commits intomofa-org:mainfrom
Ishita-190 wants to merge 6 commits intomofa-org:mainfrom
Conversation
Contributor
Author
|
@BH3GEI please take a look at this whenever you've time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Summary
PR resolves the workspace manifest mismatch preventing mofa-asr tests from running and adds baseline unit tests for the dora_integration module.
🔗 Related Issues
Closes #66
🧠 Context
The
mofa-asrcrate could not run tests due to a workspace configuration mismatch.The crate was excluded from workspace membership in the root
Cargo.toml, while its ownCargo.tomlrelied on workspace-inherited package metadata (version.workspace,edition.workspace) and dependency aliases. Because of this, Cargo could not resolve the inherited metadata when the crate was built or tested independently.Additionally, the
dora_integration.rsmodule had no unit tests. This module contains the core ASR orchestration logic responsible for command routing and lifecycle events, so the lack of tests made regressions difficult to detect.🛠️ Changes
mofa-asrmanifest configurationUpdated
apps/mofa-asr/Cargo.tomlso it no longer relies on workspace inheritance:version.workspaceandedition.workspacewith explicit package metadata.mofa-asrto build and run tests independently using--manifest-path.dora_integration.rsAdded a
#[cfg(test)]module with baseline unit tests covering:AsrEngineId-> node ID mappingAsrEngineId-> binary name mappingDataflowStoppedpoll_events()queue drain semanticsA few small adjustments were required to keep the crate compiling cleanly due to an existing makepad / moly type mismatch:
screenmodule exports during test buildsmoly_kit::widgets::live_designcall from the active pathmessages(...)extension calls with safe placeholdersThese changes only affect build/test stability and do not alter runtime behavior.
🧪 How you Tested
📸 Screenshots / Logs (if applicable)
If breaking:
🧹 Checklist
Code Quality
cargo fmtruncargo clippypasses without warningsTesting
cargo testpasses locally without any errorDocumentation
PR Hygiene
main