Feat/chat viewer bridge and bubble widget#68
Open
Nixxx19 wants to merge 8 commits intomofa-org:mainfrom
Open
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what this fixes
two connected problems, solved together:
1. silent data loss in
dispatcher.rsMofaNodeType::ChatViewerwas hittingcontinue— every chatmessage from dora was silently dropped. no error, no log, nothing.
implements
ChatViewerBridgeto complete the pipeline end-to-end.2. chat bubble widget
adds
ChatBubble(role-colored gpu-rendered bubble) andChatBubblePanel(scrollable conversation view) with fulluser / assistant / system role support.
why one pr
the bridge without the widget = messages go nowhere.
the widget without the bridge = nothing feeds it.
one feature, split across two crates.
changes
mofa-dora-bridge/src/widgets/chat_viewer_bridge.rs(new)mofa-dora-bridge/src/dispatcher.rs— replaces todo+continuemofa-ui/src/widgets/chat_bubble.rs(new)apps/mofa-test-app/src/main.rs— registry count 13→15verified