fix(dora-maas-client): update outfox-openai dependency to v0.7.0#69
Open
prabhaharanv wants to merge 1 commit intomofa-org:mainfrom
Open
fix(dora-maas-client): update outfox-openai dependency to v0.7.0#69prabhaharanv wants to merge 1 commit intomofa-org:mainfrom
prabhaharanv wants to merge 1 commit intomofa-org:mainfrom
Conversation
outfox-openai v0.2.0 never existed in the outfox repository. The crate was first published as outfox-openai at v0.6.0 (renamed from novel-openai), causing cargo to fail with "failed to select a version". Changes: - Bump outfox-openai from 0.2.0 to 0.7.0 and pin to rev 05309e0 - Enable required "chat-completion" feature flag - Fix type mismatch: use ChatCompletionRequestSystemMessageContent::Text instead of PartibleTextContent::Text for system message content
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
📋 Summary
dora-maas-clientfails to compile becauseoutfox-openai = "^0.2.0"does not match any version in the outfox repository. The crate was renamed fromnovel-openaitooutfox-openaistarting at version 0.6.0 — version 0.2.0 never existed. This PR updates the dependency to the correct version and fixes a resulting type mismatch.🔗 Related Issues
Closes #59
🧠 Context
The
outfox-openaicrate history in the outfox repo:800e8af—novel-openaiv0.3.0 (initial commit)054bff5—novel-openaiv0.6.0175b161— renamed tooutfox-openaiv0.6.005309e0—outfox-openaiv0.7.0 (latest)Since
outfox-openaiv0.2.0 never existed, Cargo fails immediately with:error: failed to select a version for the requirement outfox-openai = "^0.2.0"
candidate versions found which didn't match: 0.7.0
Additionally, v0.7.0 requires the
chat-completionfeature flag to exposespec::chat::*types and their transitive dependency onfutures. Without it, the types used by the source code are behind#[cfg]gates.🛠️ Changes
outfox-openaifrom0.2.0to0.7.0, pin to git rev05309e0, and enable thechat-completionfeatureChatCompletionRequestSystemMessageContentto imports and use it instead ofPartibleTextContent::Textfor the system message content field (type changed between API versions)🧪 How you Tested
cargo build --manifest-path node-hub/dora-maas-client/Cargo.toml— passes (warnings only, all pre-existing)cargo check --manifest-path node-hub/dora-maas-client/Cargo.toml— passescargo test --manifest-path node-hub/dora-maas-client/Cargo.toml— 5 passed, 2 failed (test_chinese_character_segmentation,test_markdown_cleaning— both are pre-existing failures insegmenter::tests, unrelated to this change; the original code doesn't compile at all)📸 Screenshots / Logs (if applicable)
Before fix:
error: failed to select a version for the requirement outfox-openai = "^0.2.0"
candidate versions found which didn't match: 0.7.0
After fix:
Finished dev profile [unoptimized + debuginfo] target(s) in 23.07s
🧹 Checklist
Code Quality
cargo fmtruncargo clippypasses without warningsTesting
cargo testpasses locally without any errorPR Hygiene
mainDocumentation
🚀 Deployment Notes (if applicable)
None.
🧩 Additional Notes for Reviewers
segmenter::testsare pre-existing — the originalmainbranch code doesn't compile at all due to this dependency bug, so those tests were already broken before this PR.cargo fmtandcargo clippycheckboxes are left unchecked because the warnings are pre-existing across the entire crate, not introduced by this change. Runningcargo fmt/clippy --fixwould create unrelated changes.