fix: replace unwrap/expect with proper error handling#74
Open
SH20RAJ wants to merge 4 commits intomofa-org:mainfrom
Open
fix: replace unwrap/expect with proper error handling#74SH20RAJ wants to merge 4 commits intomofa-org:mainfrom
SH20RAJ wants to merge 4 commits intomofa-org:mainfrom
Conversation
Fix typo 'setings' -> 'settings' in the benefits section of TabId enum documentation.
Replace panic-based error handling with Result-based error propagation and recovery mechanisms to prevent runtime crashes. Changes: - node-hub/dora-funasr-nano-mlx/src/main.rs: Handle engine None case gracefully - apps/mofa-asr/src/screen/mod.rs: Recover from poisoned mutexes in ChatController - mofa-dora-bridge/src/parser.rs: Use expect with descriptive message in test - node-hub/dora-gpt-sovits-mlx/src/ssml.rs: Use expect in test This addresses issue mofa-org#41.
- Add support for smart quotes, dashes, ellipsis, and CJK punctuation - Include digits in allowed characters - Add word boundary checks for abbreviation expansion - Add error handling for normalize_numbers and replace_consecutive_punctuation - Normalize whitespace and ensure terminal punctuation for TTS stability - Handle empty input gracefully Addresses issue mofa-org#53.
- Replace unwrap with safe error handling in dora-funasr-nano-mlx - Recover from poisoned mutexes in mofa-asr screen - Improve test error messages in parser and ssml Addresses issue mofa-org#41.
Author
|
Checked status: this PR is pending maintainer review/merge from upstream maintainers. I’m available to address feedback quickly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace panic-based error handling with Result-based error propagation and recovery mechanisms to prevent runtime crashes.
Changes:
Addresses issue #41