Skip to content

feat(kernel): add Display impl for DebugEvent telemetry#1518

Open
SH20RAJ wants to merge 1 commit intomofa-org:mainfrom
SH20RAJ:feat/988-debug-event-display
Open

feat(kernel): add Display impl for DebugEvent telemetry#1518
SH20RAJ wants to merge 1 commit intomofa-org:mainfrom
SH20RAJ:feat/988-debug-event-display

Conversation

@SH20RAJ
Copy link
Copy Markdown
Contributor

@SH20RAJ SH20RAJ commented Mar 28, 2026

Summary

  • implement Display for DebugEvent using structured single-line output: [timestamp_ms] event_type: key=value ...
  • include readable formatting for all variants (workflow_start, node_start, state_change, node_end, workflow_end, error)
  • use <none> for missing old_value and <global> for error events without node_id
  • add 8 focused unit tests covering all variants and edge cases requested in feat: add Display impl for DebugEvent telemetry type #988

Why

This improves readability for CLI logs, dashboards, and realtime telemetry streams while preserving the existing serialized event schema.

Testing

  • Added unit tests in crates/mofa-kernel/src/workflow/telemetry.rs
  • Could not execute cargo test in this environment because cargo is unavailable in PATH

Closes #988

@SH20RAJ
Copy link
Copy Markdown
Contributor Author

SH20RAJ commented Mar 28, 2026

Ready for review: this PR implements issue #988 with a Display formatter and 8 unit tests covering all variants + edge cases. Please let me know if you want any output style tweaks before merge.

@SH20RAJ
Copy link
Copy Markdown
Contributor Author

SH20RAJ commented Mar 28, 2026

Clarification: the formatter mentioned above is the Display implementation for the DebugEvent telemetry type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add Display impl for DebugEvent telemetry type

1 participant