feat(kernel): add Display impl for DebugEvent telemetry#1518
Open
SH20RAJ wants to merge 1 commit intomofa-org:mainfrom
Open
feat(kernel): add Display impl for DebugEvent telemetry#1518SH20RAJ wants to merge 1 commit intomofa-org:mainfrom
SH20RAJ wants to merge 1 commit intomofa-org:mainfrom
Conversation
Contributor
Author
|
Ready for review: this PR implements issue #988 with a Display formatter and 8 unit tests covering all variants + edge cases. Please let me know if you want any output style tweaks before merge. |
Contributor
Author
|
Clarification: the formatter mentioned above is the Display implementation for the DebugEvent telemetry type. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DisplayforDebugEventusing structured single-line output:[timestamp_ms] event_type: key=value ...workflow_start,node_start,state_change,node_end,workflow_end,error)<none>for missingold_valueand<global>for error events withoutnode_idWhy
This improves readability for CLI logs, dashboards, and realtime telemetry streams while preserving the existing serialized event schema.
Testing
crates/mofa-kernel/src/workflow/telemetry.rscargo testin this environment becausecargois unavailable in PATHCloses #988