fix(security): harden shell tool and remove dangerous defaults#1519
Open
SH20RAJ wants to merge 1 commit intomofa-org:mainfrom
Open
fix(security): harden shell tool and remove dangerous defaults#1519SH20RAJ wants to merge 1 commit intomofa-org:mainfrom
SH20RAJ wants to merge 1 commit intomofa-org:mainfrom
Conversation
… dangerous defaults (mofa-org#801)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses several critical security vulnerabilities in the
ShellCommandToolas part of issue #801.Key Changes
cat,find) from the default permitted list inShellCommandTool::new_with_defaults(). These commands can be used to bypass sandbox restrictions and read sensitive files.has_dangerous_argscheck that identifies shell operators (e.g.,|,>,<,;,&,$,`) in command arguments.These enhancements significantly improve the MoFA plugin's security posture and ensure that shell interactions remain strictly within their intended boundaries.
Addresses #801.