Skip to content

Fix declared module name, iOS modal measurement issue #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/components/ConnectedCopilotStep.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,9 @@ class ConnectedCopilotStep extends Component<Props> {
return new Promise((resolve, reject) => {
const measure = () => {
// Wait until the wrapper element appears
if (this.wrapper && this.wrapper.measure) {
this.wrapper.measure(
(ox, oy, width, height, x, y) => resolve({
if (this.wrapper && this.wrapper.measureInWindow) {
this.wrapper.measureInWindow(
(x, y, width, height) => resolve({
x, y, width, height,
}),
reject,
Expand Down
61 changes: 49 additions & 12 deletions src/hocs/copilot.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ const copilot = ({
verticalOffset = 0,
wrapperStyle,
arrowColor,
basePadding = 16,
} = {}) =>
(WrappedComponent) => {
class Copilot extends Component<any, State> {
Expand Down Expand Up @@ -86,22 +87,58 @@ const copilot = ({
getNextStep(this.state.steps, step);

setCurrentStep = async (step: Step, move?: boolean = true): void => {
await this.setState({ currentStep: step });
this.setState({ currentStep: step });
this.eventEmitter.emit('stepChange', step);

if (this.state.scrollView) {
const { scrollView } = this.state;
await this.state.currentStep.wrapper.measureLayout(
findNodeHandle(scrollView), (x, y, w, h) => {
const yOffsett = y > 0 ? y - (h / 2) : 0;
scrollView.scrollTo({ y: yOffsett, animated: false });
});
}
setTimeout(() => {
return new Promise(async (resolve) => {
if (move) {
this.moveToCurrentStep();
const { scrollView } = this.state;

if (scrollView) {
const [wrapperLayout, scrollViewLayout] = await Promise.all([
new Promise(resolve =>
this.state.currentStep.wrapper.measureLayout(
findNodeHandle(scrollView),
(...args) => resolve(args)
)
),
new Promise(resolve =>
scrollView._scrollViewRef.measure((...args) => resolve(args))
)
])

const [_x, y, _w, h] = wrapperLayout
const [_x1, _y1, _w1, height] = scrollViewLayout

const elementBottomY = y + h

// if element is not visible or barely visible in the scroll view
if (elementBottomY > height - basePadding) {
const yOffsett = elementBottomY - height + basePadding * 2

const originalHandleScroll = this.state.scrollView._scrollResponder.scrollResponderHandleScroll
this.state.scrollView._scrollResponder.scrollResponderHandleScroll = (e) => {
originalHandleScroll(e)

if (e.nativeEvent.contentOffset.y >= yOffsett) {
scrollView._scrollResponder.scrollResponderHandleScroll = originalHandleScroll

resolve()
}
}

scrollView.scrollTo({ y: yOffsett, animated: true });
} else {
resolve()
}
} else {
this.moveToCurrentStep()
resolve()
}
} else {
resolve()
}
}, this.state.scrollView ? 100 : 0);
})
}

setVisibility = (visible: boolean): void => new Promise((resolve) => {
Expand Down