Allow all charts to be generated as a dict #2361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinL
reviewed
Sep 4, 2024
| @@ -75,9 +75,12 @@ class LinkerVisualisations: | |||
| def __init__(self, linker: Linker): | |||
| self._linker = linker | |||
|
|
|||
| def match_weights_chart(self) -> ChartReturnType: | |||
| def match_weights_chart(self, as_dict: bool = True) -> ChartReturnType: | |||
There was a problem hiding this comment.
as_dict should be False by default.
i.e. all of the functions in linker.visualiastions should return an Altair chart by default, but if the user passes as_dict=True they can get back the dict representation without going through altair
I think this is also the reasons for the test failures
There was a problem hiding this comment.
That is what I intended but must have made a typo, it is updated now when you want to look again
RossHammer
force-pushed
the
allow-all-charts-as-dict
branch
from
6331207
to
deb31c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
Is your Pull Request linked to an existing Issue or Pull Request?
closes #2360
Give a brief description for the solution you have provided
I have added the
as_dictparameter to all calls in visualizations that generate a chart.PR Checklist