Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Spark 'InfinityD' bug #2374

Merged
merged 5 commits into from
Sep 3, 2024
Merged

Fix Spark 'InfinityD' bug #2374

merged 5 commits into from
Sep 3, 2024

Conversation

ADBond
Copy link
Contributor

@ADBond ADBond commented Sep 3, 2024

Type of PR

  • BUG
  • FEAT
  • MAINT
  • DOC

Is your Pull Request linked to an existing Issue or Pull Request?

Closes #2368.

Also actually implements fix from #1209, and adds in tests which trigger this issue.

Give a brief description for the solution you have provided

PR Checklist

  • Added documentation for changes
  • Added feature to example notebooks or tutorial (if appropriate)
  • Added tests (if appropriate)
  • Updated CHANGELOG.md (if appropriate)
  • Made changes based off the latest version of Splink
  • Run the linter
  • Run the spellchecker (if appropriate)

bkitej-rw and others added 4 commits September 2, 2024 17:41
in particular m/u charts lead to spark infinity/double bug
avoid attempting to cast `Infinity` to double for spark backend
@ADBond ADBond added bug Something isn't working spark labels Sep 3, 2024
@ADBond ADBond merged commit 69278a6 into master Sep 3, 2024
25 checks passed
@ADBond ADBond deleted the bug/spark-infinity-double branch September 3, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working spark
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid casting Infinity to double for Spark backend
2 participants