Splink datasets - simplify + restructure #2378
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
Is your Pull Request linked to an existing Issue or Pull Request?
Closes #2369.
Much of this is long-overdue tidying and simplifying of the over-complex code that was in place. There are a few things repeated in a couple of places now (dataset names + descriptions), but I think this is okay, as these are unlikely to change / be added to particularly frequently.
Give a brief description for the solution you have provided
Functionality is largely the same. Details:
splink_datasets
should work now even if the user does not have write permissions for the caching folder. If not, they will download directly and use without on-disk cachingPR Checklist