Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cosine similarity tests and allow schemad data #2407

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Conversation

RobinL
Copy link
Member

@RobinL RobinL commented Sep 16, 2024

This allows tests to be specified as a pyarrow table which in turn means that a stricter schema can be imposed on the incoming data.

In this case, using DuckDB, the cosine similarity function can only be used if the data is a fixed length array. When passing a python list to pyarrow, by default, this is treated as a variable length array and hence the old framework was not quite flexible enough to accomodat e

@RobinL RobinL merged commit 10a8985 into master Sep 16, 2024
25 checks passed
@RobinL RobinL deleted the add_cosine_tests branch September 16, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant