Convert t/mojo/delay.t to use subtests #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhthorsen
previously approved these changes
Oct 6, 2020
There was a problem hiding this comment.
Looks like some of the variables are not sorted alphabetically, but they weren't in the original commit either so I'm not going to request changes based on it.
https://github.com/mojolicious/mojo/pull/1568/files?w=1 looks good to me 👍
kraih
reviewed
Oct 6, 2020
kraih
reviewed
Oct 6, 2020
kraih
reviewed
Oct 6, 2020
|
A couple of follow up questions:
|
kraih
reviewed
Oct 8, 2020
t/mojo/delay.t
Outdated
|
|
||
| subtest 'Exception in first step' => sub { | ||
| my $failed; | ||
| my $result; |
There was a problem hiding this comment.
On separate lines is inconsistent.
There was a problem hiding this comment.
Very good, thanks for clarifying that the parentheses are preferred!
There was a problem hiding this comment.
The main preference is consistency. If something is unclear just look at how other files are formatted.
dz-at-tc
force-pushed
the
add_subtests_to_mojo_delay_test
branch
from
6b2c3cf to
ca13cc7
Compare
kraih
approved these changes
Oct 10, 2020
Grinnz
approved these changes
Oct 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Convert t/mojo/delay.t to use subtests.
Motivation
One more file converted.
References
Issue #1520