Convert cleanly dynamic_methods.t, user_agent_socks.t, websocket.t to use subtests #1520 #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spazm
force-pushed
the
fix/1520-next-five-subtests
branch
from
1c4dfa9 to
2d148f8
Compare
spazm
force-pushed
the
fix/1520-next-five-subtests
branch
from
3037102 to
ab1178a
Compare
spazm
force-pushed
the
fix/1520-next-five-subtests
branch
from
ab1178a to
8eea9f3
Compare
kraih
reviewed
Nov 1, 2020
| }; | ||
|
|
||
| my ($listen, $port) = (); | ||
| my ($readable, $writable) = (); |
kraih
reviewed
Nov 1, 2020
| ok !$text, 'message event has not been emitted yet'; | ||
| $fragmented_compressed->parse_message([1, 0, 0, 0, WS_CONTINUATION, substr($compressed_payload, 6)]); | ||
| is $text, 'just works', 'decoded correctly'; | ||
| my $dummy; |
kraih
reviewed
Nov 1, 2020
| ok !$writable, 'handle is not writable'; | ||
|
|
||
| # Connect | ||
| my $reactor; |
kraih
requested changes
Nov 1, 2020
|
I'm sorry, but i've decided to close these PRs, because they contain too many converted tests at once. And we don't have the review capacity to re-review the whole thing after every scoping issue fix. |
spazm
changed the title
|
Removed the tests that did not convert cleanly. The remaining tests converted cleanly and required only minimal non-whitespace changes to redeclare variables for the new scopes. PR description updated with exact details. |
spazm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Convert tests to use subtests:
dynamic_methods: single test converted cleanly to subtest.user_agent_socks.t: comment block tests converted cleanly to subtests. Only required rescoping$txvariable.websocket.t: comment block tests converted cleanly to subtests. Several variables required rescoping but there was no data shared between tests:$res,$result,$status,$stash,$code,$ws,$counter$msg.Motivation
Requests in #1520
References
Requested in #1520
There are a couple of blocks of subtests that don't seem to have tests. They may have just been labeled parts of setting up? Please feel free to revert/modify as necessary.