Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert t/mojolicious/json_config_mode_lite_app.t to use subtests #1681

Merged
merged 1 commit into from
Feb 13, 2021
Merged

convert t/mojolicious/json_config_mode_lite_app.t to use subtests #1681

merged 1 commit into from
Feb 13, 2021

Conversation

markogrady1
Copy link
Contributor

Summary

convert t/mojolicious/json_config_mode_lite_app.t to use subtests

Motivation

contributing to the subtest conversion

References

#1520

jhthorsen
jhthorsen approved these changes Jan 31, 2021
View reviewed changes
Copy link
Member

@jhthorsen jhthorsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. Didn't even have to add ?w=1 to check the diff here 👍

shadowcat-mst
shadowcat-mst approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@shadowcat-mst shadowcat-mst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 536ad9f into mojolicious:master Feb 13, 2021
@markogrady1 markogrady1 deleted the convert-json_config_mode_lite_app-to-use-subtests branch February 17, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraih kraih kraih approved these changes

@jhthorsen jhthorsen jhthorsen approved these changes

@shadowcat-mst shadowcat-mst shadowcat-mst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markogrady1 @kraih @jhthorsen @shadowcat-mst