Triggers modified_files on file deletion #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hernan604
force-pushed
the
restart_morbo_when_file_is_deleted
branch
2 times, most recently
from
2a63944 to
10cde32
Compare
|
This PR is missing a test. |
hernan604
force-pushed
the
restart_morbo_when_file_is_deleted
branch
from
10cde32 to
7c72f26
Compare
Added a test |
hernan604
force-pushed
the
restart_morbo_when_file_is_deleted
branch
2 times, most recently
from
e0e2c50 to
f537737
Compare
kraih
reviewed
Feb 5, 2024
hernan604
force-pushed
the
restart_morbo_when_file_is_deleted
branch
3 times, most recently
from
1fdfb69 to
d3063be
Compare
kraih
reviewed
Feb 6, 2024
kraih
requested review from
a team,
marcusramberg,
kraih,
jberger and
christopherraa
|
I'm in favour once all issues are resolved. |
Seconded, fix the issues and I'm in too. |
hernan604
force-pushed
the
restart_morbo_when_file_is_deleted
branch
from
d3063be to
632ae27
Compare
|
I think all issues have been resolved. If i missed something, let me know. Thanks |
jberger
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates Mojo::Server::Morbo::Backend::Poll to detect deleted files.
Motivation
Currently Mojo::Server::Morbo::Backend::Poll does not restart when files are deleted.
References
No references currently