Skip to content

fix: reject out-of-range bls private keys #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: reject out-of-range bls private keys #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions staking-cli/src/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,10 @@ def is_valid_bls_private_key(private_key: Union[int, str]) -> bool:
else:
return False # Invalid type

# Apply modulo reduction if key is larger than curve order
if key_int >= curve_order:
key_int = key_int % curve_order
if not 0 < key_int < curve_order:
return False

return 0 < key_int < curve_order
return True

def is_valid_secp256k1_private_key(hex_private_key: str) -> bool:
'''Validates a secp256k1 private key in hexadecimal format.'''
Expand Down