Set response limits on http server connections [0.18] #9775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build errors |
vtnerd
force-pushed
the
improve/rpc_threshold_0.18
branch
from
df8b58b to
fcad5b0
Compare
…ied names quick patch which fixes the issue where if you use some macros from `http_server_handlers_map2.h` you have to be in the `epee` namespace or it doesn't compile. Now can remove `using namespace epee;` from header file `core_rpc_server.h`, which caused a couple of name qualifying mistakes
vtnerd
force-pushed
the
improve/rpc_threshold_0.18
branch
from
fcad5b0 to
a2d574e
Compare
|
Yup. Sorry about that. I cherry picked a commit by @jeffro256 and included in this PR. The change is pretty simple, so I'm hoping reviewers won't turn away the additional changes (they are basically needed, or |
vtnerd
force-pushed
the
improve/rpc_threshold_0.18
branch
from
a2d574e to
d59374a
Compare
|
Another force push for a missing include. This compiles locally for me, so this may require several attempts at getting the CI to pass. |
|
I forgot that #9687 hasn't been merged. Won't bother fixing the depends builds then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #9765 but on release 0.18 branch. @selsta