ci: development build backports [0.18] #9777
Open
+347
−160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobtoht
force-pushed
the
ci_containerize_dev_rel
branch
2 times, most recently
from
94729fe to
d815d70
Compare
iamamyth
reviewed
Feb 7, 2025
| key: ccache-${{ matrix.container }}-build-${{ github.sha }} | ||
| restore-keys: ccache-${{ matrix.container }}-build- | ||
| - uses: ./.github/actions/set-make-job-count | ||
| - name: tests |
There was a problem hiding this comment.
I think you're missing the loop device setup here.
There was a problem hiding this comment.
I should amend: You dropped the test entirely, which is OK by me, although, if you dropped it because GTEST_SKIP doesn't exist in older versions of gtest, you can find the original version of the is_hdd tests PR, which didn't require GTEST_SKIP, here: master...iamamyth:monero:fix-hdd-tests-old.
Correct the unit tests for tools::is_hdd to avoid making assumptions about the configuration of a particular device based solely on the value of the __GLIBC__ preprocessor flag. Instead, rely on the test invoker to provide paths for devices of specific types via the process environment, thereby avoiding faulty assumptions and improving the specificity of test assertions. To ensure appropriate devices exist, add a script, tests/create_test_disks.sh, which configures loopback devices mirroring relevant configurations.
tobtoht
force-pushed
the
ci_containerize_dev_rel
branch
from
d815d70 to
87a8e0b
Compare
iamamyth
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates changes made to
.github/workflows/build.ymlfrommastertorelease-v0.18.The easiest way to review this PR would be to run:
I left out the Arch Linux build for now, because getting this to build on
release-v0.18will require additional changes.