-
Notifications
You must be signed in to change notification settings - Fork 209
feat(smoketests): run tests on readonly and isolated too COMPASS-8128 #6702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9d40860
run tests on readonly and isolated too
lerouxb 525f5c9
typo
lerouxb b4cb693
actually test on all the distributions
lerouxb a238371
run the read-only test suite for read-only compass builds
lerouxb cc890b4
run read-only test when the distribution is readonly
lerouxb a9d2c59
Merge branch 'main' into test-readonly-isolated
lerouxb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| import fs from 'node:fs'; | ||
| import { type SmokeTestsContext } from '../context'; | ||
| import { execute } from '../execute'; | ||
| import { getInstaller } from '../installers'; | ||
| import { createSandbox } from '../directories'; | ||
| import { getTestSubject } from '../test-subject'; | ||
|
|
||
| export async function testReadOnly(context: SmokeTestsContext) { | ||
| const sandboxPath = createSandbox(); | ||
| const { kind, appName, filepath } = await getTestSubject({ | ||
| ...context, | ||
| sandboxPath, | ||
| }); | ||
|
|
||
| try { | ||
| const install = getInstaller(kind); | ||
|
|
||
| const { appPath, uninstall } = install({ | ||
| appName, | ||
| filepath, | ||
| destinationPath: sandboxPath, | ||
| }); | ||
|
|
||
| try { | ||
| execute( | ||
| 'npm', | ||
| [ | ||
| 'run', | ||
| '--unsafe-perm', | ||
| 'test-packaged', | ||
| '--workspace', | ||
| 'compass-e2e-tests', | ||
| '--', | ||
| '--test-filter=read-only', | ||
| ], | ||
| { | ||
| // We need to use a shell to get environment variables setup correctly | ||
| shell: true, | ||
| env: { | ||
| ...process.env, | ||
| COMPASS_APP_NAME: appName, | ||
| COMPASS_APP_PATH: appPath, | ||
| }, | ||
| } | ||
| ); | ||
| } finally { | ||
| await uninstall(); | ||
| } | ||
| } finally { | ||
| if (context.skipCleanup) { | ||
| console.log(`Skipped cleaning up sandbox: ${sandboxPath}`); | ||
| } else { | ||
| console.log(`Cleaning up sandbox: ${sandboxPath}`); | ||
| fs.rmSync(sandboxPath, { recursive: true }); | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whole file is basically a copy/paste of time-to-first-query.ts. We can probably refactor it.