Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(eslint-config): update eslint to 8 #6833

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

gribnoysup
Copy link
Collaborator

I'm updating eslint to 8

Opening as draft before I go on vacation so I don't forget the state of it

  • Remove eslint-config-mongodb-js completely
    Somehow we still had a few packages with this one in dependencies
  • Update eslint to 8
    I'm not updating to 9 right away to reduce the blast radius there seems to be enough issues caused by this update already that would be nice to deal with before we're forced to adapt for the new config format on top of this
  • Update relevant eslint pugins that we depend on to latest
    Those are 8/9 compat so we can go straight to latest with them
  • Adjust rules when needed
    Some configurable eslint rules that we have changed the schema a bit, adjusted that
  • Deal with new issues reported:
    • Better detection of @typescript-eslint/no-explicit-any
    • New recommended @typescript-eslint/prefer-promise-reject-errors
    • @typescript-eslint/no-var-requires renamed to @typescript-eslint/no-require-imports
    • New recommended @typescript-eslint/no-base-to-string
    • New recommended no-unsafe-optional-chaining
    • Catch with unused err now shows up as an error
    • New recommended @typescript-eslint/no-redundant-type-constituents
    • New recommended @typescript-eslint/no-duplicate-type-constituents
    • Better detection of @typescript-eslint/unbound-method
    • New recommended @typescript-eslint/no-unsafe-declaration-merging
    • Better detection of @typescript-eslint/no-unused-expressions
    • New recommended @typescript-eslint/only-throw-error
    • New recommended @typescript-eslint/no-unsafe-enum-comparison
    • Better detection of @typescript-eslint/no-misused-promises

@gribnoysup gribnoysup added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant