fix(logger): replace PassThrough with Writable for log handling COMPASS-9736 #7222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Refactors the logger implementation to replace PassThrough stream with a custom Writable stream object for better control over log handling in the CompassWebLogger class.
- Replaces PassThrough stream with a custom Writable-like object that directly handles write and end operations
- Simplifies the logging pipeline by removing intermediate stream handling
- Maintains the same callback functionality for log processing
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Anemy
approved these changes
Aug 22, 2025
Anemy
reviewed
Aug 22, 2025
| }); | ||
| const target = { | ||
| write(line: string, callback: () => void) { | ||
| callbackRef.current.onLog?.(JSON.parse(line)); |
There was a problem hiding this comment.
Do we want to update the test ensure it's happening synchronously?
nbbeeken
force-pushed
the
CLOUDP-332732
branch
from
33c13ae to
533f97a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes