Skip to content

Conversation

kpamaran
Copy link
Collaborator

@kpamaran kpamaran commented Aug 22, 2025

Description

Adds a new getMockDataSchema method to the AtlasAiService to allow clients to generate mock data schemas from a new endpoint in the natural language api

Context: https://jira.mongodb.org/browse/CLOUDP-333849

There are no updates to the UI

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

There should be no breaking changes

This introduces a zod dependency to compass-generative-ai to leverage typescript-friendly request/response schema. I noticed there is another dependency in compass-user-data with the same minor version. I am not sure if it's worth making this a common dependency, but I find zod highly valuable for communicating contracts, validating data, and allowing users to make the most of the type system.

Since this is for a experimental MVP rolled out via a feature flag it has been labeled with "no release notes"

Dependents

Dependency of #7226

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@kpamaran kpamaran requested a review from a team as a code owner August 22, 2025 19:05
@github-actions github-actions bot added the feat label Aug 22, 2025
@kpamaran kpamaran added the no release notes Fix or feature not for release notes label Aug 22, 2025
@kpamaran kpamaran requested review from ncarbon and jcobis August 22, 2025 19:19
@kpamaran kpamaran changed the title feat(generative-ai): support mock data schema in AtlasAiService CLOUDP-333849 feat(generative-ai): get mock data schema in AtlasAiService CLOUDP-333849 Aug 22, 2025
@kpamaran kpamaran requested a review from Anemy August 22, 2025 19:33
Copy link

Assigned himanshusinghs for team compass-developers because Anemy is out of office.

@kpamaran kpamaran requested review from gribnoysup and removed request for Anemy August 22, 2025 19:38
@kpamaran kpamaran requested review from mabaasit and gagik and removed request for himanshusinghs, mabaasit and gagik August 26, 2025 15:49
@kpamaran kpamaran requested a review from ncarbon August 26, 2025 22:56
@kpamaran kpamaran removed the request for review from gribnoysup August 27, 2025 19:03
Copy link
Collaborator

@gribnoysup gribnoysup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small comments, but otherwise LGTM

@kpamaran kpamaran merged commit cd98aaf into main Aug 28, 2025
56 of 57 checks passed
@kpamaran kpamaran deleted the atlas-ai-service-get-mock-data-schema branch August 28, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat no release notes Fix or feature not for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants