-
Notifications
You must be signed in to change notification settings - Fork 230
feat(generative-ai): get mock data schema in AtlasAiService CLOUDP-333849 #7225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+469
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assigned |
ncarbon
reviewed
Aug 26, 2025
gribnoysup
reviewed
Aug 28, 2025
gribnoysup
reviewed
Aug 28, 2025
gribnoysup
reviewed
Aug 28, 2025
gribnoysup
approved these changes
Aug 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small comments, but otherwise LGTM
ncarbon
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new
getMockDataSchema
method to the AtlasAiService to allow clients to generate mock data schemas from a new endpoint in the natural language apiContext: https://jira.mongodb.org/browse/CLOUDP-333849
There are no updates to the UI
Checklist
Motivation and Context
Open Questions
There should be no breaking changes
This introduces a
zod
dependency tocompass-generative-ai
to leverage typescript-friendly request/response schema. I noticed there is another dependency incompass-user-data
with the same minor version. I am not sure if it's worth making this a common dependency, but I findzod
highly valuable for communicating contracts, validating data, and allowing users to make the most of the type system.Since this is for a experimental MVP rolled out via a feature flag it has been labeled with "no release notes"
Dependents
Dependency of #7226
Types of changes