Skip to content

fix(logger): move log line earlier COMPASS-9736 #7231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(logger): move log line earlier COMPASS-9736 #7231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions packages/compass-connections/src/stores/connections-store-redux.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1792,6 +1792,17 @@ const connectWithOptions = (
);
}

// This is used for Data Explorer connection latency tracing
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify and document why it's a fix and why it's important that this line is exactly here? Without this chances are high somebody will just move it again by accident

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, ideally I'm trynna see if I could just cover this with a test haha

log.info(
mongoLogId(1_001_000_006),
'Compass Connection Attempt Succeeded',
'Connection attempt succeeded',
{
clusterName: connectionInfo.atlasMetadata?.clusterName,
connectionId: connectionInfo.id,
}
);

track(
'New Connection',
async () => {
Expand Down Expand Up @@ -1842,17 +1853,6 @@ const connectWithOptions = (
connectionInfo
);

// This is used for Data Explorer connection latency tracing
log.info(
mongoLogId(1_001_000_006),
'Compass Connection Attempt Succeeded',
'Connection attempt succeeded',
{
clusterName: connectionInfo.atlasMetadata?.clusterName,
connectionId: connectionInfo.id,
}
);

connectionProgress.openConnectionSucceededToast(connectionInfo);

// Emit before changing state because some plugins rely on this
Expand Down
Loading