draft show shard key badge for index COMPASS-6868 #7419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
reviewed
Oct 2, 2025
| openToast, | ||
| showConfirmation as showConfirmationModal, | ||
| } from '@mongodb-js/compass-components'; | ||
| import { fetchShardingKeys } from '@mongodb-js/compass-crud'; |
There was a problem hiding this comment.
We should probably move this to data service. We already aggregate indexes state from multiple sources, might as well add another one there instead of exposing this method from crud. Maybe we can have both: an explicit method to fetch shard keys, and also adding this logic to indexes method so that this info is available on the index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes