Skip to content

Conversation

@kraenhansen
Copy link
Contributor

Description

Unblocking #7514 by separating out the upgrade and fix for the @leafygreen-ui/select

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • If this change could impact the load on the MongoDB cluster, please describe the expected and worst case impact
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@kraenhansen kraenhansen self-assigned this Nov 17, 2025
@kraenhansen kraenhansen added the no release notes Fix or feature not for release notes label Nov 17, 2025
@kraenhansen kraenhansen force-pushed the kh/leafygreen-select-update branch from 72117ae to 42a96b9 Compare November 17, 2025 22:30
Comment on lines 7828 to 7829
"node_modules/@leafygreen-ui/select/node_modules/@testing-library/dom": {
"version": "9.3.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember we were running into issues before when multiple testing-library/dom versions were in our dependency tree, not sure if this is affecting us this time, but might be worth either updating our version also or forcing this one to match ours

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dug a bit into this. Getting @testing-library/dom@9 requires @testing-library/react@14 which in turn has a peer dependency requirement of react@18.

I think for now the best cause of action would be to add an override for @testing-library/dom@8 in our root package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no release notes Fix or feature not for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants