chore: add createSessionConfig hook MCP-294 #740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new createSessionConfig hook that allows library consumers to asynchronously provide or modify configuration before establishing an MCP session. This enables use cases like fetching connection strings from secrets managers or modifying settings dynamically at session initialization time.
Key Changes:
- Added a new
createSessionConfigoptional hook toTransportRunnerConfig - Modified
setupServer()to call this hook before session initialization - Exported
TransportRunnerConfigtype for library consumers
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/transports/base.ts |
Added createSessionConfig hook to TransportRunnerConfig and modified setupServer() to use the hook's result for session initialization |
src/lib.ts |
Exported TransportRunnerConfig type to make it available to library consumers |
tests/integration/transports/createSessionConfig.test.ts |
Added comprehensive integration tests covering basic functionality, connection string modification, server integration with read-only mode, and error handling scenarios |
gagik
commented
Nov 19, 2025
| * Hook which allows library consumers to fetch configuration from external sources (e.g., secrets managers, APIs) | ||
| * or modify the existing configuration before the session is created. | ||
| */ | ||
| createSessionConfig?: CreateSessionConfigFn; |
Collaborator
Author
There was a problem hiding this comment.
I am not too sure if I understood the usecase for this correctly so let me know if this should be used differently.
Add a new async hook for library consumers to provide a configuration right before establishing an MCP session.
gagik
force-pushed
the
gagik/library-session-hook
branch
from
979a07d to
f895766
Compare
Collaborator
Pull Request Test Coverage Report for Build 19532221561Details
💛 - Coveralls |
addaleax
approved these changes
Nov 19, 2025
addaleax
reviewed
Nov 19, 2025
gagik
force-pushed
the
gagik/library-session-hook
branch
from
0c7e6ae to
ce72c96
Compare
Co-authored-by: Anna Henningsen <[email protected]>
himanshusinghs
approved these changes
Nov 20, 2025
Collaborator
himanshusinghs
left a comment
himanshusinghs
left a comment
There was a problem hiding this comment.
Yea that's precisely it. Thanks for getting it it 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new async hook for library consumers to provide a configuration right before establishing an MCP session.