Skip to content

REP-5894 Fall back to isMaster if hello fails. #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Apr 9, 2025

Conversation

FGasper
Copy link
Collaborator

@FGasper FGasper commented Apr 3, 2025

Some migrations are from source clusters old enough to lack the hello command.

This changeset teaches migration-verifier to fall back to isMaster if the hello command fails.

@FGasper FGasper force-pushed the REP-5894-fallback-from-hello branch from aab6fea to b4ac2fa Compare April 3, 2025 14:50
This reverts commit b4ac2fa.
@FGasper FGasper requested review from tdq45gj and mmcclimon and removed request for tdq45gj April 8, 2025 19:34
Copy link
Collaborator

@mmcclimon mmcclimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fascinating. LGTM, thanks!

@FGasper FGasper merged commit f5f94a1 into mongodb-labs:main Apr 9, 2025
50 checks passed
@FGasper FGasper deleted the REP-5894-fallback-from-hello branch April 9, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants