RUST-1748 Convert unsigned serde helpers to use serde_conv #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamieTsai1024
commented
Jul 17, 2025
JamieTsai1024
commented
Jul 18, 2025
| @@ -217,13 +218,18 @@ pub(crate) struct Timestamp { | |||
| body: TimestampBody, | |||
| } | |||
|
|
|||
| /// Serializes a u32 as an i64. | |||
There was a problem hiding this comment.
Moved this helper from src/serde_helpers.rs. Its use in the Timestamp serializer cannot be replaced with the new u32::AsI64 implementation since it relies on the optional dependency serde_with (behind serde_with-3 feature flag).
JamieTsai1024
commented
Jul 18, 2025
| } | ||
|
|
||
| /// Serializes a u32 as an i64. | ||
| pub fn serialize_u32_as_i64<S: Serializer>(val: &u32, serializer: S) -> Result<S::Ok, S::Error> { |
There was a problem hiding this comment.
moved to src/extjson/models.rs
isabelatkinson
approved these changes
Jul 21, 2025
This was referenced Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted unsigned (
u32,u64) converter functions insrc/serde_helpers.rsto useserde_convmacro for serializing and deserializing optional and vector fields withserde_with.<T>,Option<T>, andVec<T>fields (de)serialized using structsu32_as_timestampu32::AsTimestamp(u32 → Timestamp)timestamp_as_u32u32::FromTimestamp(Timestamp → u32)u32_as_f64u32::AsF64(u32 → f64)serialize_u32_as_i32u32::AsI32(u32 → i32)serialize_u32_as_i64u32::AsI64(u32 → i64)u64_as_f64u64::AsF64(u64 → f64)serialize_u64_as_i32u64::AsI32(u64 → i32)serialize_u64_as_i64u64::AsI64(u64 → i64)Previously:
SerializeAsandDeserializeAstraits to support Optional and Vector conversions in PR #559serde_convmacro to support Rustdocs, refactored allObjectIdconverters in PR #566DateTimeconverters PR #570