Skip to content

DOCSP-48824: v2 release #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 3, 2025
Merged

Conversation

rustagir
Copy link
Collaborator

@rustagir rustagir commented Apr 2, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-48824

Staging Links

  • whats-new
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    Copy link

    netlify bot commented Apr 2, 2025

    Deploy Preview for docs-c ready!

    Name Link
    🔨 Latest commit 4fd4a61
    🔍 Latest deploy log https://app.netlify.com/sites/docs-c/deploys/67eed71b53ab2100082505f4
    😎 Deploy Preview https://deploy-preview-107--docs-c.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Copy link
    Collaborator

    @mcmorisi mcmorisi left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM!

    @norareidy norareidy requested review from a team and kevinAlbs and removed request for a team April 2, 2025 20:22
    Copy link
    Collaborator

    @kevinAlbs kevinAlbs left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM with minor comments.

    ```````

    - If you pass the ``batchSize:0`` option to ``mongoc_client_watch``, ``mongoc_database_watch``,
    or ``mongoc_collection_watch``, the option also applies to the ``aggregate`` command.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    or ``mongoc_collection_watch``, the option also applies to the ``aggregate`` command.
    or ``mongoc_collection_watch``, the option is no longer ignored and is applied to the ``aggregate`` command.

    Suggest clarifying the option was previously ignored.

    - For the ``MONGODB-AWS`` authentication mechanism, the ``authSource`` value defaults to
    ``$external``.
    - Validates ``authMechanism`` values and returns a client error for invalid values.
    - Validates ``authMechanismProperties`` values and returns a client error for invalid
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggest clarifying what "Correctly parses colon" means. Suggest removing mention of comma character. The comma character parsing behavior did not change. Documentation was only added to note it was disallowed.

    - Validates ``authMechanismProperties`` values and returns a client error for invalid properties for the specified authentication mechanism
      - Now correctly parses colon (``:``) characters within ``authMechanismProperties`` values:
          - Old behavior: ``authMechanismProperties=A:B,C:D:E,F:G`` is parsed as ``{'A': 'B', 'C': 'D:E,F:G'}``.
          - New behavior: ``authMechanismProperties=A:B,C:D:E,F:G`` is parsed as ``{'A': 'B': 'C': 'D:E', 'F': 'G'}``.
    

    @norareidy norareidy merged commit 51903b2 into mongodb:master Apr 3, 2025
    6 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants