-
Notifications
You must be signed in to change notification settings - Fork 13
DOCSP-48824: v2 release #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor comments.
source/whats-new.txt
Outdated
``````` | ||
|
||
- If you pass the ``batchSize:0`` option to ``mongoc_client_watch``, ``mongoc_database_watch``, | ||
or ``mongoc_collection_watch``, the option also applies to the ``aggregate`` command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or ``mongoc_collection_watch``, the option also applies to the ``aggregate`` command. | |
or ``mongoc_collection_watch``, the option is no longer ignored and is applied to the ``aggregate`` command. |
Suggest clarifying the option was previously ignored.
- For the ``MONGODB-AWS`` authentication mechanism, the ``authSource`` value defaults to | ||
``$external``. | ||
- Validates ``authMechanism`` values and returns a client error for invalid values. | ||
- Validates ``authMechanismProperties`` values and returns a client error for invalid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest clarifying what "Correctly parses colon" means. Suggest removing mention of comma character. The comma character parsing behavior did not change. Documentation was only added to note it was disallowed.
- Validates ``authMechanismProperties`` values and returns a client error for invalid properties for the specified authentication mechanism
- Now correctly parses colon (``:``) characters within ``authMechanismProperties`` values:
- Old behavior: ``authMechanismProperties=A:B,C:D:E,F:G`` is parsed as ``{'A': 'B', 'C': 'D:E,F:G'}``.
- New behavior: ``authMechanismProperties=A:B,C:D:E,F:G`` is parsed as ``{'A': 'B': 'C': 'D:E', 'F': 'G'}``.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-48824
Staging Links
Self-Review Checklist