-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOSCP-43051 Get Started landing and Install #32
DOSCP-43051 Get Started landing and Install #32
Conversation
✅ Deploy Preview for docs-c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with an open question and a few tweaks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, the Linux installation instructions are technically correct. However, I fear that they way they are currently written could lead users to incorrectly assume that the version of the C driver provided by a particular version of a particular distro is adequate when it may not be for some given set of circumstances. For reference, here are the C driver versions shipped by the current active/stable distros:
EPEL7 | 1.3.6 |
EPEL8 | 1.27.6 |
EPEL9 | 1.27.6 |
Debian 10 | 1.14.0 |
Debian 11 | 1.17.6 |
Debian 12 | 1.23.1 |
Ubuntu 18.04 LTS | 1.9.2 |
Ubuntu 20.04 LTS | 1.16.1 |
Ubuntu 22.04 LTS | 1.21.0 |
Ubuntu 24.04 LTS | 1.26.0 |
Some of those are, well, really old.
Given this, it probably makes sense to recommend that before installing the available version of the C driver should be checked (with a command like apt-cache policy libmongoc-dev
on Debian/Ubuntu or sudo dnf info mongo-c-driver-devel
on RHEL/Fedora). If the version is sufficiently recent, then the package manager installation can be completed, otherwise installation should be done from source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know! Added some instructions to check the version before the installation instructions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(I am assuming that the TODO regarding installation from source will be resolved at some point, but I don't think I need to wait for that; however, I am happy to review again if more gets added for that.)
@rcsanchez97 Yes, the TODO will just be adding the link to that page once it gets standardized, but the "install from source" page itself will be reviewed separately then. |
6925e53
into
mongodb:standardization
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-43052
https://jira.mongodb.org/browse/DOCSP-43051
Staging -
Get Started
Install
Self-Review Checklist