Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-48179 add async c driver page #90

Merged

Conversation

shuangela
Copy link
Collaborator

@shuangela shuangela commented Mar 7, 2025

Pull Request Info

PR Reviewing Guidelines

Context: Ported over https://docs.google.com/document/d/1uCNyMKr5vBVil0i2WsnwaAGl-Z3qO9C3nVCgzCGpvCw/edit?tab=t.0#heading=h.tfw7my94k51h to our docs.

JIRA - https://jira.mongodb.org/browse/DOCSP-48179
Staging - https://deploy-preview-90--docs-c.netlify.app/async-c-driver/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Mar 7, 2025

Deploy Preview for docs-c ready!

Name Link
🔨 Latest commit 0ec3be3
🔍 Latest deploy log https://app.netlify.com/sites/docs-c/deploys/67d04d8257ecff0008eee65f
😎 Deploy Preview https://deploy-preview-90--docs-c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@rachel-mack rachel-mack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was didn't edit for Vale rules because this is kind of market-y, so I don't think they should apply. I tried to make the call to action a little more concise at the bottom.

covering the configuration, building, and usage of the library.
- `Tutorials <https://mongodb-labs.github.io/mongo-c-driver-async/learn/>`__ to walk you through
common use cases and showcase the potential of asynchronous operations.
- List of `amongoc features <https://mongodb-labs.github.io/mongo-c-driver-async/ref/features/>`__
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- List of `amongoc features <https://mongodb-labs.github.io/mongo-c-driver-async/ref/features/>`__
- A list of `amongoc features <https://mongodb-labs.github.io/mongo-c-driver-async/ref/features/>`__

- `Tutorials <https://mongodb-labs.github.io/mongo-c-driver-async/learn/>`__ to walk you through
common use cases and showcase the potential of asynchronous operations.
- List of `amongoc features <https://mongodb-labs.github.io/mongo-c-driver-async/ref/features/>`__
- `amongoc’s design considerations <https://mongodb-labs.github.io/mongo-c-driver-async/explain/consider/>`__
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `amongoc’s design considerations <https://mongodb-labs.github.io/mongo-c-driver-async/explain/consider/>`__
- Descriptions of `amongoc’s design considerations <https://mongodb-labs.github.io/mongo-c-driver-async/explain/consider/>`__

- `amongoc’s design considerations <https://mongodb-labs.github.io/mongo-c-driver-async/explain/consider/>`__
and `amongoc’s asynchrony model <https://mongodb-labs.github.io/mongo-c-driver-async/explain/async-model/>`__

Here’s a simple application that initializes an asynchronous event loop and attempts to establish a connection to a local MongoDB server using the ``amongoc`` library.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Here’s a simple application that initializes an asynchronous event loop and attempts to establish a connection to a local MongoDB server using the ``amongoc`` library.
The following example is an application that initializes an asynchronous event loop and attempts to establish a connection to a local MongoDB server using the ``amongoc`` library:

Comment on lines 77 to 83
This public preview release is focused on gathering user feedback to inform the architectural
decisions for a production-ready version. We invite you to try out ``amongoc`` and share your thoughts,
suggestions, and issues. Please participate in GitHub `discussions <https://github.com/mongodb-labs/mongo-c-driver-async/discussions>`__ and `issues <https://github.com/mongodb-labs/mongo-c-driver-async/issues>`__ to
provide your feedback, especially about the interface and build & runtime requirements. Over the next few months,
our goal is to collect as much user input as possible to align with the needs and expectations of
our user community. Your feedback is invaluable, and we eagerly look forward to hearing from you
and seeing what you'll create with ``amongoc``!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This public preview release is focused on gathering user feedback to inform the architectural
decisions for a production-ready version. We invite you to try out ``amongoc`` and share your thoughts,
suggestions, and issues. Please participate in GitHub `discussions <https://github.com/mongodb-labs/mongo-c-driver-async/discussions>`__ and `issues <https://github.com/mongodb-labs/mongo-c-driver-async/issues>`__ to
provide your feedback, especially about the interface and build & runtime requirements. Over the next few months,
our goal is to collect as much user input as possible to align with the needs and expectations of
our user community. Your feedback is invaluable, and we eagerly look forward to hearing from you
and seeing what you'll create with ``amongoc``!
This public preview release is focused on gathering user feedback to inform the architectural
decisions for a production-ready version of ``amongoc``. We invite you to share your thoughts,
suggestions, and issues in GitHub `discussions <https://github.com/mongodb-labs/mongo-c-driver-async/discussions>`__ and `issues <https://github.com/mongodb-labs/mongo-c-driver-async/issues>`__. We are especially interested in your opinions about the interface, and the build and runtime requirements. Our goal is to collect as much user input as possible to align with the needs and expectations of
our user community.
Your feedback is invaluable, and we eagerly look forward to hearing from you
and seeing what you'll create with ``amongoc``!

source/index.txt Outdated
@@ -14,6 +14,7 @@
Indexes </indexes>
Monitor Your Application </monitoring>
Security </security>
amongoc Public Preview </async-c-driver>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would move this to the very top, above Get Started - unless they're told in advance, people aren't going to know to look for this, so it needs to be super visible.

Suggested change
amongoc Public Preview </async-c-driver>
Public Preview: amongoc </async-c-driver>

.. _c-async-driver:

======================
amongoc Public Preview
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
amongoc Public Preview
Public Preview: amongoc

@shuangela shuangela requested a review from bisht2050 March 10, 2025 18:36
.. _c-async-driver:

=======================
Public Preview: amongoc
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we reword the title to something more user/SEO friendly:
"Async C Driver: Public Preview"

Asynchronous programming allows applications to remain responsive while waiting for
I/O operations to complete, making it ideal for high-performance, network-intensive
use cases. ``amongoc`` will also facilitate the integration of MongoDB into asynchronous
frameworks like Drogon. Notably, it has also been the top requested feature for the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shuangela shuangela requested a review from bisht2050 March 11, 2025 15:05
@bisht2050
Copy link
Collaborator

The text in sidebar doesn't match the title (Asynchronous vs Async). Is this intended?

image

@shuangela
Copy link
Collaborator Author

The text in sidebar doesn't match the title (Asynchronous vs Async). Is this intended?

image

Hi @bisht2050, yes this was intentional: it's ok for our table of contents titles to not match the titles on the page. The reason why I changed it is that asynchronous sounded more formal for me, however if you'd prefer to keep async due to preference from the C driver community or if async will be widely understood, I'm happy to change it back!

@shuangela shuangela merged commit 2b66272 into mongodb:master Mar 11, 2025
4 of 5 checks passed
shuangela added a commit that referenced this pull request Mar 11, 2025
* add async c driver page

* change title

* revert wording

* fix bulleted list

* fix vale error

* move c code to seperate file

* fix include

* rm edits

* fix typo

* rb feedback

(cherry picked from commit 2b66272)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants