Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C] Duplicate Titles - Connect to MongoDB #93

Merged
merged 4 commits into from
Mar 11, 2025

Conversation

rachel-mack
Copy link
Collaborator

@rachel-mack rachel-mack commented Mar 10, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-48229

Merging the Get Started section into one page, per the new TOC guidelines
Ignoring language-related vale complaints because this is all c+p.

Staging - https://deploy-preview-93--docs-c.netlify.app/get-started/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Mar 10, 2025

Deploy Preview for docs-c ready!

Name Link
🔨 Latest commit d23fdda
🔍 Latest deploy log https://app.netlify.com/sites/docs-c/deploys/67cf4619a570260008ae05c9
😎 Deploy Preview https://deploy-preview-93--docs-c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@lindseymoore lindseymoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! Left comments about capitalizing the titles showing up in the page TOC. Also not sure if the Connect to MongoDB section is staging correctly (it isn't showing up at all on my end)

.. _c-get-started-connect-to-mongodb:

Connect to MongoDB
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I: This section isn't showing up in staging for some reason :/ Not sure if it's just on my end

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, this is showing up for me (also, I renamed it, Run a Sample Query)
https://deploy-preview-93--docs-c.netlify.app/get-started/#run-a-sample-query

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I see it now! Netlify strikes again :(

Copy link
Collaborator

@lindseymoore lindseymoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM!

@rachel-mack rachel-mack merged commit 5717c5c into mongodb:master Mar 11, 2025
6 of 7 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 11, 2025
github-actions bot pushed a commit that referenced this pull request Mar 11, 2025
@rachel-mack rachel-mack deleted the DOCSP-48229 branch March 11, 2025 14:43
rachel-mack added a commit that referenced this pull request Mar 11, 2025
(cherry picked from commit 5717c5c)

Co-authored-by: Rachel Mackintosh <[email protected]>
rachel-mack added a commit that referenced this pull request Mar 11, 2025
(cherry picked from commit 5717c5c)

Co-authored-by: Rachel Mackintosh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants