Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set() stage builder #512

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

norareidy
Copy link
Collaborator

@norareidy norareidy commented Mar 11, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-33526

Staging Links

  • fundamentals/builders
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    Copy link

    netlify bot commented Mar 11, 2025

    Deploy Preview for docs-csharp ready!

    Name Link
    🔨 Latest commit 870787f
    🔍 Latest deploy log https://app.netlify.com/sites/docs-csharp/deploys/67ed443c87ec4e0008c92e8a
    😎 Deploy Preview https://deploy-preview-512--docs-csharp.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Copy link
    Collaborator

    @mongoKart mongoKart left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    @norareidy norareidy requested review from a team and rstam and removed request for a team March 12, 2025 14:04

    var pipeline = new EmptyPipelineDefinition<Flower>()
    .Match(matchFilter)
    .Set(fields);
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Have you tried executing this?

    Most likely it will throw an exception when reading the results from the server because the C# declaration for Flower does not have a Color property.

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Ah yep, I added Color to the Flower class while testing and just added it to the page. But does that defeat the purpose of Set()?

    @norareidy norareidy requested a review from rstam April 4, 2025 17:29
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants