DOCSP-47834 clarify batch size #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jordan-smith721
approved these changes
Mar 17, 2025
| batch size of ``101`` documents and a maximum size of 16 | ||
| mebibytes (MiB) for each subsequent batch. This option can | ||
| enforce a smaller limit than 16 MiB, but not a larger one. If | ||
| you set ``batchSize`` to a limit that results in batches |
There was a problem hiding this comment.
Suggested change
| you set ``batchSize`` to a limit that results in batches | |
| you set ``batchSize`` to a limit that results in batches |
shuangela
requested review from
a team and
JamesKovacs
and removed request for
a team
BorisDog
requested changes
Mar 24, 2025
| * - ``batchSize`` | ||
| - | Specifies the maximum number of documents that a change | ||
| stream can return in each batch, which applies to ``Watch()`` or | ||
| ``WatchAsync()``. By default, watch functions have an initial |
There was a problem hiding this comment.
We should clarify what "By default" means: that batchSize is optional and if batchSize parameter is not set watch function have...
Otherwise it might sound like the default is batchSize == 101 in the option objects.
There was a problem hiding this comment.
The lead in text to the table states that all these options are optional, and I added a clarification on what "by default" means on both this page and the other page I edited!
github-actions bot
pushed a commit
that referenced
this pull request
Mar 25, 2025
* clarify batch size * change find * clarify no effect * fix wrapping * remove extra space * review (cherry picked from commit 9d38c02)
github-actions bot
pushed a commit
that referenced
this pull request
Mar 25, 2025
* clarify batch size * change find * clarify no effect * fix wrapping * remove extra space * review (cherry picked from commit 9d38c02)
github-actions bot
pushed a commit
that referenced
this pull request
Mar 25, 2025
* clarify batch size * change find * clarify no effect * fix wrapping * remove extra space * review (cherry picked from commit 9d38c02)
github-actions bot
pushed a commit
that referenced
this pull request
Mar 25, 2025
* clarify batch size * change find * clarify no effect * fix wrapping * remove extra space * review (cherry picked from commit 9d38c02)
github-actions bot
pushed a commit
that referenced
this pull request
Mar 25, 2025
* clarify batch size * change find * clarify no effect * fix wrapping * remove extra space * review (cherry picked from commit 9d38c02)
This was referenced Mar 25, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Mar 25, 2025
* clarify batch size * change find * clarify no effect * fix wrapping * remove extra space * review (cherry picked from commit 9d38c02)
github-actions bot
pushed a commit
that referenced
this pull request
Mar 25, 2025
* clarify batch size * change find * clarify no effect * fix wrapping * remove extra space * review (cherry picked from commit 9d38c02)
This was referenced Mar 25, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Mar 25, 2025
* clarify batch size * change find * clarify no effect * fix wrapping * remove extra space * review (cherry picked from commit 9d38c02)
github-actions bot
pushed a commit
that referenced
this pull request
Mar 25, 2025
* clarify batch size * change find * clarify no effect * fix wrapping * remove extra space * review (cherry picked from commit 9d38c02)
shuangela
added a commit
that referenced
this pull request
Mar 25, 2025
* clarify batch size * change find * clarify no effect * fix wrapping * remove extra space * review (cherry picked from commit 9d38c02) Co-authored-by: shuangela <[email protected]>
shuangela
added a commit
that referenced
this pull request
Mar 25, 2025
* clarify batch size * change find * clarify no effect * fix wrapping * remove extra space * review (cherry picked from commit 9d38c02) Co-authored-by: shuangela <[email protected]>
shuangela
added a commit
that referenced
this pull request
Mar 25, 2025
* clarify batch size * change find * clarify no effect * fix wrapping * remove extra space * review (cherry picked from commit 9d38c02) Co-authored-by: shuangela <[email protected]>
shuangela
added a commit
that referenced
this pull request
Mar 25, 2025
* clarify batch size * change find * clarify no effect * fix wrapping * remove extra space * review (cherry picked from commit 9d38c02) Co-authored-by: shuangela <[email protected]>
shuangela
added a commit
that referenced
this pull request
Mar 25, 2025
* clarify batch size * change find * clarify no effect * fix wrapping * remove extra space * review (cherry picked from commit 9d38c02) Co-authored-by: shuangela <[email protected]>
shuangela
added a commit
that referenced
this pull request
Mar 25, 2025
* clarify batch size * change find * clarify no effect * fix wrapping * remove extra space * review (cherry picked from commit 9d38c02) Co-authored-by: shuangela <[email protected]>
shuangela
added a commit
that referenced
this pull request
Mar 25, 2025
* clarify batch size * change find * clarify no effect * fix wrapping * remove extra space * review (cherry picked from commit 9d38c02) Co-authored-by: shuangela <[email protected]>
shuangela
added a commit
that referenced
this pull request
Mar 25, 2025
* clarify batch size * change find * clarify no effect * fix wrapping * remove extra space * review (cherry picked from commit 9d38c02) Co-authored-by: shuangela <[email protected]>
shuangela
added a commit
that referenced
this pull request
Mar 25, 2025
* clarify batch size * change find * clarify no effect * fix wrapping * remove extra space * review (cherry picked from commit 9d38c02) Co-authored-by: shuangela <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-47834
Staging Links
Self-Review Checklist