-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-45943: dateonly serialization #570
base: master
Are you sure you want to change the base?
DOCSP-45943: dateonly serialization #570
Conversation
✅ Deploy Preview for docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
e171ba6
to
64727cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM w/ 2 suggestions
- ``Representation``: Set to a ``BsonType`` instance that specifies how | ||
the ``DateOnly`` value is stored in MongoDB. | ||
|
||
- ``DocumentFormat``: Set to one of the following |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think here we need to spcify that DocumentFormat
is an optional parameter and that is used only if Representation
is BsonType.Document
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good, just a small comment to clarify.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-45943
Staging Links
Self-Review Checklist