Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-45943: dateonly serialization #570

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rustagir
Copy link
Collaborator

@rustagir rustagir commented Apr 4, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-45943

Staging Links

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Apr 4, 2025

Deploy Preview for docs-csharp ready!

Name Link
🔨 Latest commit 043d985
🔍 Latest deploy log https://app.netlify.com/sites/docs-csharp/deploys/67f552dee2207f0008c889c1
😎 Deploy Preview https://deploy-preview-570--docs-csharp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rustagir rustagir force-pushed the DOCSP-45943-dateonly-serialization branch from e171ba6 to 64727cd Compare April 4, 2025 18:24
Copy link
Collaborator

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ 2 suggestions

@rustagir rustagir requested a review from papafe April 7, 2025 13:59
- ``Representation``: Set to a ``BsonType`` instance that specifies how
the ``DateOnly`` value is stored in MongoDB.

- ``DocumentFormat``: Set to one of the following
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here we need to spcify that DocumentFormat is an optional parameter and that is used only if Representation is BsonType.Document.

Copy link

@papafe papafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good, just a small comment to clarify.

@rustagir rustagir requested a review from papafe April 8, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants