Skip to content

DOCSP-49621 Customize cluster settings #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

stephmarie17
Copy link
Collaborator

@stephmarie17 stephmarie17 commented Jun 18, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-49621

Staging Links

Customize Cluster Settings

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?
  • Are the page titles greater than 20 characters long and SEO relevant?

Copy link

netlify bot commented Jun 18, 2025

Deploy Preview for docs-golang ready!

Name Link
🔨 Latest commit be26ae9
🔍 Latest deploy log https://app.netlify.com/projects/docs-golang/deploys/68656306a595a200082c450a
😎 Deploy Preview https://deploy-preview-522--docs-golang.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@docs-builder-bot
Copy link

docs-builder-bot commented Jun 23, 2025

🔄 Deploy Preview for docs-golang processing

Item Details
🔨 Latest Commit f86117ed43eebc3a3154026569c1e262c04c3494
😎 Deploy Preview https://deploy-preview-522--docs-golang.netlify.app
🔍 Build Logs View Logs

@stephmarie17 stephmarie17 marked this pull request as ready for review June 23, 2025 17:46
@stephmarie17 stephmarie17 changed the title DOCSP-49621 Customize server options DOCSP-49621 Customize cluster settings Jun 23, 2025
Copy link
Collaborator

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Mainly requesting changes because of the question I left

@stephmarie17 stephmarie17 requested a review from norareidy July 1, 2025 15:53
Copy link
Collaborator

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with final suggestions!

@stephmarie17 stephmarie17 requested review from a team and matthewdale and removed request for a team July 1, 2025 22:27
Copy link
Collaborator

@matthewdale matthewdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One optional suggestion, otherwise looks good! 👍

Comment on lines 14 to 16
const (
uri = "mongodb://localhost:27017/?serverSelectionTimeoutMS=10000&localThresholdMS=20"
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Optional) Consider removing the unnecessary parens.

Suggested change
const (
uri = "mongodb://localhost:27017/?serverSelectionTimeoutMS=10000&localThresholdMS=20"
)
const uri = "mongodb://localhost:27017/?serverSelectionTimeoutMS=10000&localThresholdMS=20"

@stephmarie17 stephmarie17 merged commit 8cac163 into mongodb:comp-cov Jul 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants