-
Notifications
You must be signed in to change notification settings - Fork 34
DOCSP-49621 Customize cluster settings #522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-49621 Customize cluster settings #522
Conversation
✅ Deploy Preview for docs-golang ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🔄 Deploy Preview for docs-golang processing
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Mainly requesting changes because of the question I left
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with final suggestions!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One optional suggestion, otherwise looks good! 👍
const ( | ||
uri = "mongodb://localhost:27017/?serverSelectionTimeoutMS=10000&localThresholdMS=20" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Optional) Consider removing the unnecessary parens.
const ( | |
uri = "mongodb://localhost:27017/?serverSelectionTimeoutMS=10000&localThresholdMS=20" | |
) | |
const uri = "mongodb://localhost:27017/?serverSelectionTimeoutMS=10000&localThresholdMS=20" |
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-49621
Staging Links
Customize Cluster Settings
Self-Review Checklist