Skip to content

DOCSP-49974 Configure CRUD Operations #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: comp-cov
Choose a base branch
from

Conversation

stephmarie17
Copy link
Collaborator

@stephmarie17 stephmarie17 commented Jun 23, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-49974

Staging Links

Configure CRUD Operations

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?
  • Are the page titles greater than 20 characters long and SEO relevant?

Copy link

netlify bot commented Jun 23, 2025

Deploy Preview for docs-golang ready!

Name Link
🔨 Latest commit ba99a97
🔍 Latest deploy log https://app.netlify.com/projects/docs-golang/deploys/68659aa8a595a200083723f2
😎 Deploy Preview https://deploy-preview-524--docs-golang.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@docs-builder-bot
Copy link

docs-builder-bot commented Jun 23, 2025

🔄 Deploy Preview for docs-golang processing

Item Details
🔨 Latest Commit ac563a19ee2c658097ffd003096683f451b9a860
😎 Deploy Preview https://deploy-preview-524--docs-golang.netlify.app
🔍 Build Logs View Logs

@stephmarie17 stephmarie17 marked this pull request as ready for review June 30, 2025 22:28
Copy link
Collaborator

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks really good overall. some suggestions for clarity and style guide (sorry if this is all stuff you didn't write 🥲 )

Comment on lines 69 to 70
concern using the ``SetWriteConcern()`` method with a ``WriteConcern``
type. The ``WriteConcern`` type has the following methods to
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: what does 'with a WriteConcern type' mean?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this wording is unclear, will reword to clarify!


If you apply a new collation to an operation that differs from an index's collation,
you cannot use that index. As a result, the operation may not perform as optimally as one
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
you cannot use that index. As a result, the operation may not perform as optimally as one
you cannot use that index. As a result, the operation may not perform as well as one

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This angered vale but I think it doesn't understand the usage here 🫠

@stephmarie17 stephmarie17 requested a review from mongoKart July 1, 2025 23:26
Copy link
Collaborator

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple small things then LGTM!

@stephmarie17 stephmarie17 requested review from a team and prestonvasquez and removed request for a team July 2, 2025 21:47
@stephmarie17
Copy link
Collaborator Author

stephmarie17 commented Jul 2, 2025

Note for technical reviewer @prestonvasquez : this PR does not have any new code examples, it is just moving them to follow the comprehensive coverage version of the docs table of contents that we're working on in this feature branch. However, if you can do a quick review to make sure the technical content/examples are still up-to-date and don't require any changes, that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants