-
Notifications
You must be signed in to change notification settings - Fork 34
DOCSP-49974 Configure CRUD Operations #524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: comp-cov
Are you sure you want to change the base?
DOCSP-49974 Configure CRUD Operations #524
Conversation
✅ Deploy Preview for docs-golang ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🔄 Deploy Preview for docs-golang processing
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks really good overall. some suggestions for clarity and style guide (sorry if this is all stuff you didn't write 🥲 )
source/crud/configure.txt
Outdated
concern using the ``SetWriteConcern()`` method with a ``WriteConcern`` | ||
type. The ``WriteConcern`` type has the following methods to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q: what does 'with a WriteConcern type' mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this wording is unclear, will reword to clarify!
source/crud/configure.txt
Outdated
|
||
If you apply a new collation to an operation that differs from an index's collation, | ||
you cannot use that index. As a result, the operation may not perform as optimally as one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you cannot use that index. As a result, the operation may not perform as optimally as one | |
you cannot use that index. As a result, the operation may not perform as well as one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This angered vale but I think it doesn't understand the usage here 🫠
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple small things then LGTM!
Note for technical reviewer @prestonvasquez : this PR does not have any new code examples, it is just moving them to follow the comprehensive coverage version of the docs table of contents that we're working on in this feature branch. However, if you can do a quick review to make sure the technical content/examples are still up-to-date and don't require any changes, that would be great! |
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-49974
Staging Links
Configure CRUD Operations
Self-Review Checklist