-
Notifications
You must be signed in to change notification settings - Fork 34
DOCSP-47011: Extended JSON #528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-golang ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🔄 Deploy Preview for docs-golang processing
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with small suggestions!
source/data-formats.txt
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: Can you mark this page with no index, so it is not searchable?
bidirectional conversion without loss of information. The **Relaxed | ||
mode** format is more concise and closer to ordinary JSON, but does not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bidirectional conversion without loss of information. The **Relaxed | |
mode** format is more concise and closer to ordinary JSON, but does not | |
bidirectional conversion without loss of information. The **Relaxed | |
Mode** format is more concise and closer to ordinary JSON, but does not |
<https://datatracker.ietf.org/doc/html/rfc8259>`__ and meets specific | ||
use cases. | ||
|
||
The **extended** format, also known as the **canonical** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The **extended** format, also known as the **canonical** | |
The **Extended** format, also known as the **canonical** |
S: Since it's capitalized in the table.
// end-unmarshal | ||
|
||
// begin-marshal | ||
var person = Person{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
person
is redeclared from L34.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Use a consistent pattern for the print in L40, L58, and L67.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-47011
Staging Links
Self-Review Checklist