Skip to content

DOCSP-51824 Standardize Run a Command usage ex #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025

Conversation

lindseymoore
Copy link
Collaborator

@lindseymoore lindseymoore commented Jul 23, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-51824

Staging Links

https://deploy-preview-545--docs-golang.netlify.app/run-command/#run-a-command-example--full-file

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?
  • Are the page titles greater than 20 characters long and SEO relevant?

Copy link

netlify bot commented Jul 23, 2025

Deploy Preview for docs-golang ready!

Name Link
🔨 Latest commit 0564d5a
🔍 Latest deploy log https://app.netlify.com/projects/docs-golang/deploys/68813b06709d140008921feb
😎 Deploy Preview https://deploy-preview-545--docs-golang.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@docs-builder-bot
Copy link

🔄 Deploy Preview for docs-golang processing

Item Details
🔨 Latest Commit 301b107e7b242fb9c805b87067b2e29a74de7d62
😎 Deploy Preview https://deploy-preview-545--docs-golang.netlify.app
🔍 Build Logs View Logs

@lindseymoore lindseymoore requested review from a team and prestonvasquez and removed request for a team July 23, 2025 20:00
@lindseymoore
Copy link
Collaborator Author

lindseymoore commented Jul 23, 2025

Question for technical reviewer: Is there an efficient way to supply the command as a struct? Thank you!

@prestonvasquez
Copy link
Member

Question for technical reviewer: Is there an efficient way to supply the command as a struct? Thank you!

For the reasons described here, I would suggest not using a struct for the command.

@lindseymoore
Copy link
Collaborator Author

lindseymoore commented Jul 25, 2025

Sounds good! Is this PR good to go then? @prestonvasquez

Copy link

@mballard-mdb mballard-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@lindseymoore lindseymoore merged commit c8365c3 into mongodb:comp-cov Jul 28, 2025
5 checks passed
rachel-mack pushed a commit to rachel-mack/docs-golang that referenced this pull request Jul 30, 2025
rachel-mack pushed a commit to rachel-mack/docs-golang that referenced this pull request Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants