-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-46758 Change Run Command page title #1009
DOCSP-46758 Change Run Command page title #1009
Conversation
✅ Deploy Preview for docs-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I'm thinking for these title changes that are needed for pages in the Usage Example section, it might suffice to just add 'Example' to the end of the title. I can check in with Sarah about this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No URL change needed. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than shortening the TOC title, LGTM! Let me know if you have any questions
source/usage-examples.txt
Outdated
@@ -26,7 +26,7 @@ Usage Examples | |||
Delete </usage-examples/delete-operations> | |||
Count Documents </usage-examples/count> | |||
Distinct Field Values </usage-examples/distinct> | |||
Run a Command </usage-examples/command> | |||
Run a Command Example </usage-examples/command> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run a Command Example </usage-examples/command> | |
Run a Command </usage-examples/command> |
I would leave Example out of the TOC title to make the title concise. In the TOC, the page is already in the Usage Example section, so users can use that context to know the page is an example. Let me know if this make sense to you, thanks!
* Change Run Command page title * add example to the end of usage examples page * remove example (cherry picked from commit 5436319)
* Change Run Command page title * add example to the end of usage examples page * remove example (cherry picked from commit 5436319)
* Change Run Command page title * add example to the end of usage examples page * remove example (cherry picked from commit 5436319)
* Change Run Command page title * add example to the end of usage examples page * remove example (cherry picked from commit 5436319)
* Change Run Command page title * add example to the end of usage examples page * remove example (cherry picked from commit 5436319)
* Change Run Command page title * add example to the end of usage examples page * remove example (cherry picked from commit 5436319)
* Change Run Command page title * add example to the end of usage examples page * remove example (cherry picked from commit 5436319)
* Change Run Command page title * add example to the end of usage examples page * remove example (cherry picked from commit 5436319)
* Change Run Command page title * add example to the end of usage examples page * remove example (cherry picked from commit 5436319)
* Change Run Command page title * add example to the end of usage examples page * remove example (cherry picked from commit 5436319)
* Change Run Command page title * add example to the end of usage examples page * remove example (cherry picked from commit 5436319)
* Change Run Command page title * add example to the end of usage examples page * remove example (cherry picked from commit 5436319)
💔 Some backports could not be createdNote: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-46758
Staging - https://deploy-preview-1009--docs-node.netlify.app/fundamentals/run-command/
Self-Review Checklist