Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-46758 Change Run Command page title #1009

Merged

Conversation

shuangela
Copy link
Collaborator

@shuangela shuangela commented Mar 3, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-46758
Staging - https://deploy-preview-1009--docs-node.netlify.app/fundamentals/run-command/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Sorry, something went wrong.

Copy link

netlify bot commented Mar 3, 2025

Deploy Preview for docs-node ready!

Name Link
🔨 Latest commit a4bae52
🔍 Latest deploy log https://app.netlify.com/sites/docs-node/deploys/67c72f8c8b7588000843c3f8
😎 Deploy Preview https://deploy-preview-1009--docs-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lindseymoore
Copy link
Collaborator

I'm thinking for these title changes that are needed for pages in the Usage Example section, it might suffice to just add 'Example' to the end of the title. I can check in with Sarah about this.

@shuangela shuangela requested review from sarahemlin and removed request for sarahemlin March 3, 2025 21:07
Copy link
Collaborator

@sarahemlin sarahemlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No URL change needed. Thank you!

Copy link
Collaborator

@lindseymoore lindseymoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than shortening the TOC title, LGTM! Let me know if you have any questions

@@ -26,7 +26,7 @@ Usage Examples
Delete </usage-examples/delete-operations>
Count Documents </usage-examples/count>
Distinct Field Values </usage-examples/distinct>
Run a Command </usage-examples/command>
Run a Command Example </usage-examples/command>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Run a Command Example </usage-examples/command>
Run a Command </usage-examples/command>

I would leave Example out of the TOC title to make the title concise. In the TOC, the page is already in the Usage Example section, so users can use that context to know the page is an example. Let me know if this make sense to you, thanks!

@shuangela shuangela merged commit 5436319 into mongodb:master Mar 4, 2025
5 checks passed
shuangela added a commit to shuangela/docs-node that referenced this pull request Mar 4, 2025
* Change Run Command page title

* add example to the end of usage examples page

* remove example

(cherry picked from commit 5436319)
shuangela added a commit to shuangela/docs-node that referenced this pull request Mar 4, 2025
* Change Run Command page title

* add example to the end of usage examples page

* remove example

(cherry picked from commit 5436319)
shuangela added a commit to shuangela/docs-node that referenced this pull request Mar 4, 2025
* Change Run Command page title

* add example to the end of usage examples page

* remove example

(cherry picked from commit 5436319)
shuangela added a commit to shuangela/docs-node that referenced this pull request Mar 4, 2025
* Change Run Command page title

* add example to the end of usage examples page

* remove example

(cherry picked from commit 5436319)
shuangela added a commit to shuangela/docs-node that referenced this pull request Mar 4, 2025
* Change Run Command page title

* add example to the end of usage examples page

* remove example

(cherry picked from commit 5436319)
shuangela added a commit to shuangela/docs-node that referenced this pull request Mar 4, 2025
* Change Run Command page title

* add example to the end of usage examples page

* remove example

(cherry picked from commit 5436319)
shuangela added a commit to shuangela/docs-node that referenced this pull request Mar 4, 2025
* Change Run Command page title

* add example to the end of usage examples page

* remove example

(cherry picked from commit 5436319)
shuangela added a commit to shuangela/docs-node that referenced this pull request Mar 4, 2025
* Change Run Command page title

* add example to the end of usage examples page

* remove example

(cherry picked from commit 5436319)
shuangela added a commit to shuangela/docs-node that referenced this pull request Mar 4, 2025
* Change Run Command page title

* add example to the end of usage examples page

* remove example

(cherry picked from commit 5436319)
shuangela added a commit to shuangela/docs-node that referenced this pull request Mar 4, 2025
* Change Run Command page title

* add example to the end of usage examples page

* remove example

(cherry picked from commit 5436319)
shuangela added a commit to shuangela/docs-node that referenced this pull request Mar 4, 2025
* Change Run Command page title

* add example to the end of usage examples page

* remove example

(cherry picked from commit 5436319)
shuangela added a commit to shuangela/docs-node that referenced this pull request Mar 4, 2025
* Change Run Command page title

* add example to the end of usage examples page

* remove example

(cherry picked from commit 5436319)
@shuangela
Copy link
Collaborator Author

💔 Some backports could not be created

Status Branch Result
v6.14
v6.13
v6.12
v6.11
v6.10
v6.9
v6.8
v6.7
v6.6
v6.5
v6.4
v6.3
v6.2 Conflict resolution was aborted by the user
v6.1 Conflict resolution was aborted by the user
v6.0 Conflict resolution was aborted by the user

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

backport --pr 1009

Questions ?

Please refer to the Backport tool documentation

shuangela added a commit that referenced this pull request Mar 4, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* Change Run Command page title

* add example to the end of usage examples page

* remove example

(cherry picked from commit 5436319)
shuangela added a commit that referenced this pull request Mar 4, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* Change Run Command page title

* add example to the end of usage examples page

* remove example

(cherry picked from commit 5436319)
shuangela added a commit that referenced this pull request Mar 4, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* Change Run Command page title

* add example to the end of usage examples page

* remove example

(cherry picked from commit 5436319)
shuangela added a commit that referenced this pull request Mar 4, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* Change Run Command page title

* add example to the end of usage examples page

* remove example

(cherry picked from commit 5436319)
shuangela added a commit that referenced this pull request Mar 4, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* Change Run Command page title

* add example to the end of usage examples page

* remove example

(cherry picked from commit 5436319)
shuangela added a commit that referenced this pull request Mar 4, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* Change Run Command page title

* add example to the end of usage examples page

* remove example

(cherry picked from commit 5436319)
shuangela added a commit that referenced this pull request Mar 4, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* Change Run Command page title

* add example to the end of usage examples page

* remove example

(cherry picked from commit 5436319)
shuangela added a commit that referenced this pull request Mar 4, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* Change Run Command page title

* add example to the end of usage examples page

* remove example

(cherry picked from commit 5436319)
shuangela added a commit that referenced this pull request Mar 4, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* Change Run Command page title

* add example to the end of usage examples page

* remove example

(cherry picked from commit 5436319)
shuangela added a commit that referenced this pull request Mar 4, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* Change Run Command page title

* add example to the end of usage examples page

* remove example

(cherry picked from commit 5436319)
shuangela added a commit that referenced this pull request Mar 4, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* Change Run Command page title

* add example to the end of usage examples page

* remove example

(cherry picked from commit 5436319)
shuangela added a commit that referenced this pull request Mar 4, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* Change Run Command page title

* add example to the end of usage examples page

* remove example

(cherry picked from commit 5436319)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants