-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-4466 Add CSOT #951
DOCSP-4466 Add CSOT #951
Conversation
✅ Deploy Preview for docs-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall good, thanks for taking this! Some suggestions for clarity and small fixes. I'll be back Jan 7, but Mike says he is available for re-review if you want it back a little sooner. Have a great holiday break!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lots of comments, but they're all small. great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple small things but otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comments and fix, great work on this! LGTM :)
If you specify the ``timeoutMS`` option, the driver automatically applies the | ||
specified timeout to each server operation. The following code example specifies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's per operation. Cursors introduce their own complexity of lifetime or per iteration. But there's no concept of a total timeout for all operations performed on a client.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
looks like there's a linter error of sorts. Unfortunately, killCursors is the name of the command so that can't be rephrased 😅
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v6.11 v6.11
# Navigate to the new working tree
cd .worktrees/backport-v6.11
# Create a new branch
git switch --create backport-951-to-v6.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a2ff55820ea825b358442947ee0cfe64ad2c2eca
# Push it to GitHub
git push --set-upstream origin backport-951-to-v6.11
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v6.11 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v6.12 v6.12
# Navigate to the new working tree
cd .worktrees/backport-v6.12
# Create a new branch
git switch --create backport-951-to-v6.12
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a2ff55820ea825b358442947ee0cfe64ad2c2eca
# Push it to GitHub
git push --set-upstream origin backport-951-to-v6.12
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v6.12 Then, create a pull request where the |
(cherry picked from commit a2ff558)
(cherry picked from commit a2ff558)
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-44666
Staging - https://deploy-preview-951--docs-node.netlify.app/fundamentals/connection/csot/
Self-Review Checklist