Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-4466 Add CSOT #951

Merged
merged 18 commits into from
Jan 15, 2025
Merged

Conversation

stephmarie17
Copy link
Collaborator

@stephmarie17 stephmarie17 commented Dec 13, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-44666
Staging - https://deploy-preview-951--docs-node.netlify.app/fundamentals/connection/csot/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Dec 14, 2024

Deploy Preview for docs-node ready!

Name Link
🔨 Latest commit 41bfff1
🔍 Latest deploy log https://app.netlify.com/sites/docs-node/deploys/678826011c9c3d000843c89e
😎 Deploy Preview https://deploy-preview-951--docs-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stephmarie17 stephmarie17 marked this pull request as ready for review December 18, 2024 17:25
Copy link
Collaborator

@lindseymoore lindseymoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good, thanks for taking this! Some suggestions for clarity and small fixes. I'll be back Jan 7, but Mike says he is available for re-review if you want it back a little sooner. Have a great holiday break!

Copy link
Collaborator

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of comments, but they're all small. great work!

@stephmarie17 stephmarie17 requested a review from mongoKart January 6, 2025 22:03
Copy link
Collaborator

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple small things but otherwise LGTM

Copy link
Collaborator

@lindseymoore lindseymoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments and fix, great work on this! LGTM :)

@dariakp dariakp requested a review from nbbeeken January 14, 2025 16:03
Comment on lines 71 to 72
If you specify the ``timeoutMS`` option, the driver automatically applies the
specified timeout to each server operation. The following code example specifies
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's per operation. Cursors introduce their own complexity of lifetime or per iteration. But there's no concept of a total timeout for all operations performed on a client.

@stephmarie17 stephmarie17 requested a review from nbbeeken January 15, 2025 21:21
Copy link
Collaborator

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

looks like there's a linter error of sorts. Unfortunately, killCursors is the name of the command so that can't be rephrased 😅

@stephmarie17 stephmarie17 merged commit a2ff558 into mongodb:master Jan 15, 2025
6 of 7 checks passed
@stephmarie17 stephmarie17 deleted the docsp-44666-csot branch January 15, 2025 22:07
Copy link

The backport to v6.11 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v6.11 v6.11
# Navigate to the new working tree
cd .worktrees/backport-v6.11
# Create a new branch
git switch --create backport-951-to-v6.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a2ff55820ea825b358442947ee0cfe64ad2c2eca
# Push it to GitHub
git push --set-upstream origin backport-951-to-v6.11
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v6.11

Then, create a pull request where the base branch is v6.11 and the compare/head branch is backport-951-to-v6.11.

Copy link

The backport to v6.12 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v6.12 v6.12
# Navigate to the new working tree
cd .worktrees/backport-v6.12
# Create a new branch
git switch --create backport-951-to-v6.12
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a2ff55820ea825b358442947ee0cfe64ad2c2eca
# Push it to GitHub
git push --set-upstream origin backport-951-to-v6.12
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v6.12

Then, create a pull request where the base branch is v6.12 and the compare/head branch is backport-951-to-v6.12.

stephmarie17 added a commit that referenced this pull request Jan 15, 2025
(cherry picked from commit a2ff558)
stephmarie17 added a commit that referenced this pull request Jan 15, 2025
(cherry picked from commit a2ff558)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants