DOCSP-43919: aggregation builder #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-php-library ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rustagir
force-pushed
the
DOCSP-43919-agg-builder
branch
from
a654c02 to
30da9a6
Compare
5 tasks
lindseymoore
approved these changes
Feb 10, 2025
source/aggregation.txt
Outdated
| #. Create an array to store the pipeline stages | ||
|
|
||
| #. For each stage, call an operator method from the ``Stage`` | ||
| builder class to create that type of aggregation stage |
There was a problem hiding this comment.
Suggested change
| builder class to create that type of aggregation stage | |
| builder class to create an aggregation stage of that type |
S: Optional rewording, to put emphasis on the stage
source/aggregation.txt
Outdated
Comment on lines
90
to
94
| - :ref:`php-aggregation-array-api`: Create aggregation pipelines by | ||
| passing arrays that specify the aggregation operators and parameters | ||
| - :ref:`php-aggregation-builder-api`: Create aggregation pipelines by using native |
There was a problem hiding this comment.
Q: Any guidelines on linking to sections on the same page within text and without a proper introduction? Was a little thrown off when this just led me to the section right beneath. If the team usually does this, it's alright. Could remove links if not.
rustagir
force-pushed
the
DOCSP-43919-agg-builder
branch
from
0b38fc5 to
70bcf6c
Compare
rustagir
requested review from
a team and
jmikola
and removed request for
a team
jmikola
reviewed
Feb 13, 2025
jmikola
approved these changes
Feb 13, 2025
rustagir
added a commit
that referenced
this pull request
Mar 6, 2025
* use sharedincludes in compat page * add source constants for versions * delete files for old build system (cherry picked from commit 55daa82) * adds more info to v1.20 whats new (cherry picked from commit 302bcd5) * Fix compatibility table (cherry picked from commit 4fba22f) * (DOCSP-44298) Removed EOL'd v1.16 and earlier. (#165) (#166) * DOCSP-44903 Shorten TOC Labels (#176) * DOCSP-44903 Shorten TOC Labels * rest of pages * angle brackets * fixes * internal review * updates based on Mike's PR * review comments and consistency (cherry picked from commit b9fda16) * PHPLIB-1278: FAQ entry on connection persistence * Address vale lint checks on word usage * Docs edits * Merge pull request #181 from mcmorisi/DRIVERS-2658-hint DOCSP-45139: Add Hint option for Distinct operation * (DOCSP-45749) Denests last phase 1 nested components (#182) * (DOCSP-45749) Denests last phase 1 nested components * Update build * DOCSP-45100: Delete and rename by name (#187) * DOCSP-45100: Delete and rename by name * edits * JM feedback (cherry picked from commit 343f339) * bring master changes into v1.21 * DOCSP-44644: db/coll accessor methods * fix spacing * vale action dependency * vale action dependency * DOCSP-45100: GridFS methods api docs (#196) * DOCSP-45100: GridFS methods api docs * edits * RR feedback * JT feedback * DOCSP-45100: GridFS methods api docs (#196) * DOCSP-45100: GridFS methods api docs * edits * RR feedback * JT feedback (cherry picked from commit 1442347) * DOCSP-43365: type specification for createSearchIndex(es) * indentation fix * indentation fix * add whats new entry * indentation fix * SA PR fixes 1 * DOCSP-43365: type specification for createSearchIndex(es) (cherry picked from commit e09b124) * indentation fix (cherry picked from commit cd6a586) * indentation fix (cherry picked from commit 3b3ec37) * add whats new entry (cherry picked from commit f821030) * SA PR fixes 1 (cherry picked from commit 7d9bfe8) * DOCSP-43457: builderEncoder option (#200) * DOCSP-43457: builderEncoder option * fix * fix type * go back * codec * JT feedback * DOCSP-43457: builderEncoder option (#200) * DOCSP-43457: builderEncoder option * fix * fix type * go back * codec * JT feedback (cherry picked from commit e1ed056) * DOCSP-44237 flags Option deprecation on v2.21 (#201) * DOCSP-44237 flags Option deprecation on v2.21 * add what's new note * Rea review comments * DOCSP-45770: atlas search queries (#197) * DOCSP-45770: atlas search queries * fix indentation * fix indentation * fix indentation * fix indentation * snooty landing page * snooty landing page * indentation fix * netlify trigger * whats new * RM PR fixes 1 * comments * small fix * JT tech review 1 * indentation fix * fix * small fixes * small fixes * remov Pipeline type * DOCSP-45878: Transactions parallelism note (#204) * DOCSP-45878: Transactions parallelism note (#204) (cherry picked from commit ba91a37) * DOCSP-43919: aggregation builder (#203) * DOCSP-43919: aggregation builder * indentation fix * remov Pipeline type * LM PR fixes 1 * fp fixes * todo fixes * small fixes * JM tech review 1 * DOCSP-46127: Update manual link (#205) * DOCSP-46127: Update manual link * MW feedback * DOCSP-46127: Update manual link (#205) * DOCSP-46127: Update manual link * MW feedback (cherry picked from commit bf6ac8a) * DOCSP-47690: aws lambda tutorial (#207) * DOCSP-47690: aws lambda tutorial * fixes * fixes * fixes * MM PR fixes 1 * remove section * RB small fix * DOCSP-47690: aws lambda tutorial (#207) * DOCSP-47690: aws lambda tutorial * fixes * fixes * fixes * MM PR fixes 1 * remove section * RB small fix (cherry picked from commit 8ed8dde) * add redirect for aws lambda page * change title to avoid duplicate * change toc * change url and add redirects * add back old ref based on rea's feedback * change redirect * fix merge issues * use regular includes on master * DOCSP-47970: v1.21 release (#212) * DOCSP-47970: v1.21 release * JM combine v's * JT small fix (#209) * DOCSP-43464: operations with builders (#206) * DOCSP-43464: operations with builders * fix desc * shared include fix? * shared include fix? * revert * netlify trigger * small fix * LM PR fixes 1 * LM PR fixes 2 * link fix * reformat comments * JT tech review 2 * fix code example * JT tech review comments --------- Co-authored-by: Jordan Smith <[email protected]> Co-authored-by: Elyse Foreman <[email protected]> Co-authored-by: lindseymoore <[email protected]> Co-authored-by: Jeremy Mikola <[email protected]> Co-authored-by: Michael Morisi <[email protected]> Co-authored-by: Sarah Simpers <[email protected]> Co-authored-by: Nora Reidy <[email protected]> Co-authored-by: Angela <[email protected]> Co-authored-by: shuangela <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-43919
Staging -
Self-Review Checklist