Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCSP-43464: operations with builders #206

Merged
merged 14 commits into from
Mar 3, 2025
Merged

DOCSP-43464: operations with builders #206

merged 14 commits into from
Mar 3, 2025

Conversation

rustagir
Copy link
Contributor

@rustagir rustagir commented Feb 18, 2025 •
edited
Loading

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-43464
Staging - https://deploy-preview-206--docs-php-library.netlify.app/builders/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

@netlify Netlify
Copy link

netlify bot commented Feb 18, 2025 •
edited
Loading

✅ Deploy Preview for docs-php-library ready!

Name Link
🔨 Latest commit 3724c51
🔍 Latest deploy log https://app.netlify.com/sites/docs-php-library/deploys/67c5ca6df27af800086fc7fc
😎 Deploy Preview https://deploy-preview-206--docs-php-library.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

lindseymoore
lindseymoore requested changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@lindseymoore lindseymoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! A few suggestions

lindseymoore
lindseymoore requested changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@lindseymoore lindseymoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more small things

lindseymoore
lindseymoore approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@lindseymoore lindseymoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 404, otherwise LGTM, Thanks!

@rustagir rustagir requested review from a team and GromNaN and removed request for a team February 19, 2025 20:23
@rustagir rustagir requested a review from GromNaN February 20, 2025 14:39
GromNaN
GromNaN reviewed Feb 21, 2025
View reviewed changes
@rustagir rustagir requested a review from GromNaN February 21, 2025 20:36
@rustagir rustagir changed the base branch from v1.21 to master February 28, 2025 19:00
GromNaN
GromNaN reviewed Feb 28, 2025
View reviewed changes
source/builders.txt Outdated
documents. To learn more about updating documents, see the
:ref:`php-write-update` guide.

.. important:: Only $set Operator Supported in Update Documents
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's confusing.
Update supports an aggregation pipeline, in that case most of the stages can be used.

Or by default that's update operators that are not supported by the builder yet. They are not stages even if the syntax for $set is similar.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I remove this admonition then? I looked at the server docs for agg pipelines in update operations and saw that only a subset of operators are usable, such as $set.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you can remove it. We will try to add this as a new feature: PHPLIB-1638

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready for another look!

@rustagir rustagir force-pushed the DOCSP-43464-builder-for-queries branch from 8dbc428 to 3724c51 Compare March 3, 2025 15:27
@rustagir rustagir requested a review from GromNaN March 3, 2025 15:28
@rustagir rustagir merged commit e6182b8 into mongodb:master Mar 3, 2025
5 of 7 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 3, 2025
@rustagir @github-actions
DOCSP-43464: operations with builders (#206)
c658d71 
* DOCSP-43464: operations with builders

* fix desc

* shared include fix?

* shared include fix?

* revert

* netlify trigger

* small fix

* LM PR fixes 1

* LM PR fixes 2

* link fix

* reformat comments

* JT tech review 2

* fix code example

* JT tech review comments

(cherry picked from commit e6182b8)
@github-actions github-actions bot mentioned this pull request Mar 3, 2025
Closed
rustagir added a commit that referenced this pull request Mar 3, 2025
@rustagir
DOCSP-43464: operations with builders (#206)
1c07346 
* DOCSP-43464: operations with builders

* fix desc

* shared include fix?

* shared include fix?

* revert

* netlify trigger

* small fix

* LM PR fixes 1

* LM PR fixes 2

* link fix

* reformat comments

* JT tech review 2

* fix code example

* JT tech review comments

(cherry picked from commit e6182b8)
rustagir added a commit that referenced this pull request Mar 6, 2025
@rustagir @jordan-smith721
@elyse-mdb @lindseymoore @jmikola @mcmorisi @sarahsimpers @norareidy @shuangela
Merge v1.21 changes that were merged into master into v2.0 (#216)
acbdfe1 
* use sharedincludes in compat page

* add source constants for versions

* delete files for old build system

(cherry picked from commit 55daa82)

* adds more info to v1.20 whats new

(cherry picked from commit 302bcd5)

* Fix compatibility table

(cherry picked from commit 4fba22f)

* (DOCSP-44298) Removed EOL'd v1.16 and earlier. (#165) (#166)

* DOCSP-44903 Shorten TOC Labels (#176)

* DOCSP-44903 Shorten TOC Labels

* rest of pages

* angle brackets

* fixes

* internal review

* updates based on Mike's PR

* review comments and consistency

(cherry picked from commit b9fda16)

* PHPLIB-1278: FAQ entry on connection persistence

* Address vale lint checks on word usage

* Docs edits

* Merge pull request #181 from mcmorisi/DRIVERS-2658-hint

DOCSP-45139: Add Hint option for Distinct operation

* (DOCSP-45749) Denests last phase 1 nested components (#182)

* (DOCSP-45749) Denests last phase 1 nested components

* Update build

* DOCSP-45100: Delete and rename by name (#187)

* DOCSP-45100: Delete and rename by name

* edits

* JM feedback

(cherry picked from commit 343f339)

* bring master changes into v1.21

* DOCSP-44644: db/coll accessor methods

* fix spacing

* vale action dependency

* vale action dependency

* DOCSP-45100: GridFS methods api docs (#196)

* DOCSP-45100: GridFS methods api docs

* edits

* RR feedback

* JT feedback

* DOCSP-45100: GridFS methods api docs (#196)

* DOCSP-45100: GridFS methods api docs

* edits

* RR feedback

* JT feedback

(cherry picked from commit 1442347)

* DOCSP-43365: type specification for createSearchIndex(es)

* indentation fix

* indentation fix

* add whats new entry

* indentation fix

* SA PR fixes 1

* DOCSP-43365: type specification for createSearchIndex(es)

(cherry picked from commit e09b124)

* indentation fix

(cherry picked from commit cd6a586)

* indentation fix

(cherry picked from commit 3b3ec37)

* add whats new entry

(cherry picked from commit f821030)

* SA PR fixes 1

(cherry picked from commit 7d9bfe8)

* DOCSP-43457: builderEncoder option (#200)

* DOCSP-43457: builderEncoder option

* fix

* fix type

* go back

* codec

* JT feedback

* DOCSP-43457: builderEncoder option (#200)

* DOCSP-43457: builderEncoder option

* fix

* fix type

* go back

* codec

* JT feedback

(cherry picked from commit e1ed056)

* DOCSP-44237 flags Option deprecation on v2.21 (#201)

* DOCSP-44237 flags Option deprecation on v2.21

* add what's new note

* Rea review comments

* DOCSP-45770: atlas search queries (#197)

* DOCSP-45770: atlas search queries

* fix indentation

* fix indentation

* fix indentation

* fix indentation

* snooty landing page

* snooty landing page

* indentation fix

* netlify trigger

* whats new

* RM PR fixes 1

* comments

* small fix

* JT tech review 1

* indentation fix

* fix

* small fixes

* small fixes

* remov Pipeline type

* DOCSP-45878: Transactions parallelism note (#204)

* DOCSP-45878: Transactions parallelism note (#204)

(cherry picked from commit ba91a37)

* DOCSP-43919: aggregation builder (#203)

* DOCSP-43919: aggregation builder

* indentation fix

* remov Pipeline type

* LM PR fixes 1

* fp fixes

* todo fixes

* small fixes

* JM tech review 1

* DOCSP-46127: Update manual link (#205)

* DOCSP-46127: Update manual link

* MW feedback

* DOCSP-46127: Update manual link (#205)

* DOCSP-46127: Update manual link

* MW feedback

(cherry picked from commit bf6ac8a)

* DOCSP-47690: aws lambda tutorial (#207)

* DOCSP-47690: aws lambda tutorial

* fixes

* fixes

* fixes

* MM PR fixes 1

* remove section

* RB small fix

* DOCSP-47690: aws lambda tutorial (#207)

* DOCSP-47690: aws lambda tutorial

* fixes

* fixes

* fixes

* MM PR fixes 1

* remove section

* RB small fix

(cherry picked from commit 8ed8dde)

* add redirect for aws lambda page

* change title to avoid duplicate

* change toc

* change url and add redirects

* add back old ref based on rea's feedback

* change redirect

* fix merge issues

* use regular includes on master

* DOCSP-47970: v1.21 release (#212)

* DOCSP-47970: v1.21 release

* JM combine v's

* JT small fix (#209)

* DOCSP-43464: operations with builders (#206)

* DOCSP-43464: operations with builders

* fix desc

* shared include fix?

* shared include fix?

* revert

* netlify trigger

* small fix

* LM PR fixes 1

* LM PR fixes 2

* link fix

* reformat comments

* JT tech review 2

* fix code example

* JT tech review comments

---------

Co-authored-by: Jordan Smith <[email protected]>
Co-authored-by: Elyse Foreman <[email protected]>
Co-authored-by: lindseymoore <[email protected]>
Co-authored-by: Jeremy Mikola <[email protected]>
Co-authored-by: Michael Morisi <[email protected]>
Co-authored-by: Sarah Simpers <[email protected]>
Co-authored-by: Nora Reidy <[email protected]>
Co-authored-by: Angela <[email protected]>
Co-authored-by: shuangela <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GromNaN GromNaN GromNaN approved these changes

@lindseymoore lindseymoore lindseymoore approved these changes

Assignees
No one assigned
Labels
backport v1.21
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rustagir @GromNaN @lindseymoore