DOCSP-48606: builderEncoder Database#232
Merged
rustagir merged 4 commits intomongodb:masterfrom Mar 24, 2025
Merged
Conversation
✅ Deploy Preview for docs-php-library ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
shuangela
approved these changes
Mar 21, 2025
source/whats-new.txt
Outdated
| - :phpmethod:`Database constructor <MongoDB\Database::__construct()>` | ||
| - :phpmethod:`MongoDB\Database::withOptions()` | ||
| - :phpmethod:`Collection constructor <MongoDB\Collection::__construct()>` | ||
| - :phpmethod:`MongoDB\Collection::withOptions()` methods |
Collaborator
There was a problem hiding this comment.
S: Because you say "the following methods" in the lead in text, I don't think you need the word "methods" after the MongoDB\Collection::withOptions() bullet point.
Contributor
Author
There was a problem hiding this comment.
oops! that was left over from an earlier commit. fixing
rustagir
requested review from
a team and
jmikola
and removed request for
a team
jmikola
reviewed
Mar 21, 2025
| query and aggregation options. If omitted, the ``Database`` | ||
| instance uses the default encoder. | ||
|
|
||
| .. versionadded:: 1.21.1 |
Contributor
There was a problem hiding this comment.
This can be 1.21.
PHPLIB-1646 only fixed a bug with this method not inheriting the existing Database's option.
If builderEncoder is explicitly provided in the $options array (which is what this is documenting), it was always passed along to construct the new Database instance.
jmikola
approved these changes
Mar 22, 2025
rustagir
added a commit
that referenced
this pull request
Mar 24, 2025
* DOCSP-48606: builderEncoder Database * wip * AS PR fixes 1 * JM small fix (cherry picked from commit 9a0e1cb)
rustagir
added a commit
that referenced
this pull request
Mar 24, 2025
* DOCSP-48606: builderEncoder Database * wip * AS PR fixes 1 * JM small fix (cherry picked from commit 9a0e1cb)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-48606
Staging -
DB api ref
Collection api ref
whats new
Self-Review Checklist