-
Notifications
You must be signed in to change notification settings - Fork 33
DOCSP-44581: v2 release #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-php-library ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- ✓ | ||
- ✓ | ||
- ✓ | ||
- ✓ [#deprecation-note]_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the PHPLIB 2.0.0 release notes, MongoDB 4.2+ is reported:
MongoDB 4.2+ Required: Future versions of the library will require MongoDB 4.2 or later. MongoDB 4.0 support is deprecated.
That seems to contradict itself, as there doesn't appear to be anything in PHPLIB that drops support for MongoDB 4.0.
In the corresponding PHPC release notes, the deprecation of MongoDB 4.0 is only mentioned in 1.21.0 and there is nothing about that mentioned in the 2.0.0 notes. I think that was an oversight and the 2.0.0 notes should simply have repeated the notice about an upcoming deprecation for MongoDB 4.0.
I think the compatibility table in this PR is correct, but wanted to drop a comment here so @alcaeus or @GromNaN can correct the release notes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strictly speaking, announcing the deprecation in 1.21.0 covers us and the note in 2.0.0 is not strictly required. I've added the same note to the PHPC release notes nonetheless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, I'll leave the table as is then! Thanks for the info!
* DOCSP-44581: v2 release * small fix (cherry picked from commit 14380e9)
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-44581
Staging Links
Self-Review Checklist