Skip to content

DOCSP-44581: v2 release #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2025
Merged

Conversation

rustagir
Copy link
Contributor

@rustagir rustagir commented Apr 10, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-44581

Staging Links

  1. compat
  2. whats new

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?
  • Are the page titles greater than 20 characters long and SEO relevant?

Copy link

netlify bot commented Apr 10, 2025

Deploy Preview for docs-php-library ready!

Name Link
🔨 Latest commit 36bb897
🔍 Latest deploy log https://app.netlify.com/sites/docs-php-library/deploys/67f7c89cdfd8fa00082e50ee
😎 Deploy Preview https://deploy-preview-234--docs-php-library.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@jordan-smith721 jordan-smith721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rustagir rustagir requested review from a team, GromNaN and jmikola and removed request for a team April 10, 2025 14:10
Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I might suggest waiting on @alcaeus or @GromNaN to sign off on this so they can acknowledge my comment.

- ✓
- ✓
- ✓
- ✓ [#deprecation-note]_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the PHPLIB 2.0.0 release notes, MongoDB 4.2+ is reported:

MongoDB 4.2+ Required: Future versions of the library will require MongoDB 4.2 or later. MongoDB 4.0 support is deprecated.

That seems to contradict itself, as there doesn't appear to be anything in PHPLIB that drops support for MongoDB 4.0.

In the corresponding PHPC release notes, the deprecation of MongoDB 4.0 is only mentioned in 1.21.0 and there is nothing about that mentioned in the 2.0.0 notes. I think that was an oversight and the 2.0.0 notes should simply have repeated the notice about an upcoming deprecation for MongoDB 4.0.

I think the compatibility table in this PR is correct, but wanted to drop a comment here so @alcaeus or @GromNaN can correct the release notes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking, announcing the deprecation in 1.21.0 covers us and the note in 2.0.0 is not strictly required. I've added the same note to the PHPC release notes nonetheless.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I'll leave the table as is then! Thanks for the info!

@alcaeus alcaeus removed the request for review from GromNaN April 11, 2025 08:26
@rustagir rustagir merged commit 14380e9 into mongodb:master Apr 11, 2025
6 checks passed
rustagir added a commit that referenced this pull request Apr 11, 2025
* DOCSP-44581: v2 release

* small fix

(cherry picked from commit 14380e9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants