DOCSP-48327: Address technical feedback on Logging page #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-pymongo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
NoahStapp
suggested changes
Mar 12, 2025
source/logging.txt
Outdated
|
|
||
| .. code-block:: none | ||
|
|
||
| INFO:pymongo.mongo_client:MongoClient opened default port on mongodb://localhost:27017/ |
There was a problem hiding this comment.
Can we use a pymongo.command log message here to match the example above?
NoahStapp
suggested changes
Mar 13, 2025
source/logging.txt
Outdated
|
|
||
| .. code-block:: none | ||
|
|
||
| INFO:pymongo.command:Command insert on namespace test.test_collection |
There was a problem hiding this comment.
We should use an actual log message here, like this:
DEBUG:pymongo.command:{"clientId": {"$oid": "65cbe82614be1fc2beb4e4a9"}, "message": "Command started", "command": "{\"insert\": \"test\", \"ordered\": true, \"lsid\": {\"id\": {\"$binary\": {\"base64\": \"GI7ubVhPSsWd7+OwHEFx6Q==\", \"subType\": \"04\"}}}, \"$db\": \"db\", \"documents\": [{\"x\": 1, \"_id\": {\"$oid\": \"65cbe82614be1fc2beb4e4aa\"}}]}", "commandName": "insert", "databaseName": "db", "requestId": 1144108930, "operationId": 1144108930, "driverConnectionId": 1, "serverConnectionId": 3554, "serverHost": "localhost", "serverPort": 27017}
NoahStapp
approved these changes
Mar 13, 2025
mcmorisi
added a commit
that referenced
this pull request
Mar 13, 2025
(cherry picked from commit 15d495b)
mcmorisi
added a commit
that referenced
this pull request
Mar 13, 2025
(cherry picked from commit 15d495b)
mcmorisi
added a commit
that referenced
this pull request
Mar 13, 2025
(cherry picked from commit 15d495b)
mcmorisi
added a commit
that referenced
this pull request
Mar 13, 2025
(cherry picked from commit 15d495b)
mcmorisi
added a commit
that referenced
this pull request
Mar 13, 2025
(cherry picked from commit 15d495b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-48327
Staging Links
Self-Review Checklist