Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-35744 geospatial page #229

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

shuangela
Copy link
Collaborator

@shuangela shuangela commented Mar 18, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-37544

Staging Links

  • geo
  • index
  • indexes
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    Copy link

    netlify bot commented Mar 18, 2025

    Deploy Preview for docs-pymongo ready!

    Name Link
    🔨 Latest commit fbbfc80
    🔍 Latest deploy log https://app.netlify.com/sites/docs-pymongo/deploys/67d9d0e6ee91f800081ead09
    😎 Deploy Preview https://deploy-preview-229--docs-pymongo.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Copy link
    Collaborator

    @mcmorisi mcmorisi left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM with some small things!

    source/geo.txt Outdated
    Comment on lines 41 to 45
    - GeoJSON, a format that represents geospatial data on an earth-like
    sphere.

    - Legacy coordinate pairs, a format that represents geospatial data
    on a Euclidean plane.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Nit

    Suggested change
    - GeoJSON, a format that represents geospatial data on an earth-like
    sphere.
    - Legacy coordinate pairs, a format that represents geospatial data
    on a Euclidean plane.
    - GeoJSON, a format that represents geospatial data on an earth-like
    sphere
    - Legacy coordinate pairs, a format that represents geospatial data
    on a Euclidean plane

    source/geo.txt Outdated
    Comment on lines 90 to 94
    {
    "type": "Point",
    "coordinates": [-73.856077, 40.848447]
    }

    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Applies to all the dictionaries on this page.

    Suggested change
    {
    "type": "Point",
    "coordinates": [-73.856077, 40.848447]
    }
    {
    "type": "Point",
    "coordinates": [-73.856077, 40.848447]
    }

    source/geo.txt Outdated
    Comment on lines 139 to 140
    Legacy coordinate pairs are represented by an array of two values, in which the first
    represents the ``x`` axis value and the second represents the ``y`` axis value.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Nit

    Suggested change
    Legacy coordinate pairs are represented by an array of two values, in which the first
    represents the ``x`` axis value and the second represents the ``y`` axis value.
    Legacy coordinate pairs are represented by an array of two values, in which the first value
    represents the ``x`` axis value and the second represents the ``y`` axis value.

    - ``2dsphere``, used for GeoJSON data
    - ``2d``, used for legacy coordinate pairs

    To learn more about how to create geospatial indexes, see the :ref:`geospatial-indexes`
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Broken link at the moment, you'll need to add the geospatial-indexes ref to the Indexes landing page.

    source/geo.txt Outdated
    Comment on lines 226 to 232
    The results of the preceding example contain the following documents:

    .. code-block:: json
    :copyable: False

    { "_id" : ObjectId("59a47287cfa9a3a73e51e8e2"), "theaterId" : 1908 }
    { "_id" : ObjectId("59a47286cfa9a3a73e51e838"), "theaterId" : 1448 }
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Nit: For this example and the next one you could combine this with the code example using the io-code-block component.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants