DOCSP-48170: Async examples for Serialization/Third Party Tools #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-pymongo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
NoahStapp
suggested changes
Mar 24, 2025
source/tools.txt
Outdated
| _ = monkey.patch_all() | ||
| from pymongo import MongoClient | ||
| client = MongoClient() | ||
| # You must call patch_all() *before* importing any other modules |
There was a problem hiding this comment.
The async API doesn't support using gevent. That should be explicitly called out in the docs, where would the best place be to do so?
There was a problem hiding this comment.
Probably either in the breaking changes page or on the forthcoming Sync vs. Async page. In the meantime, can undo this change here.
There was a problem hiding this comment.
Does it make sense to add a little callout here saying that AsyncMongoClient doesn't support gevent?
NoahStapp
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-48170
Staging Links
Self-Review Checklist