Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-48161: Async examples for Connect pages #236

Merged
merged 5 commits into from
Mar 24, 2025

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Mar 21, 2025

Copy link

netlify bot commented Mar 21, 2025

Deploy Preview for docs-pymongo ready!

Name Link
🔨 Latest commit 9f3f89d
🔍 Latest deploy log https://app.netlify.com/sites/docs-pymongo/deploys/67e1722772a4f500082fab78
😎 Deploy Preview https://deploy-preview-236--docs-pymongo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggested a few small improvements!

@mcmorisi mcmorisi requested a review from rustagir March 21, 2025 15:44
Copy link
Collaborator

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@@ -97,6 +97,17 @@ instance on port ``27017`` of ``localhost``:
uri = "mongodb://localhost:27017/"
client = MongoClient(uri)

If you must use an asynchronous version of the ``MongoClient`` class, use the

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this sentence aiming to communicate? It's a little unclear to me what "if you must use an asynchronous version...` means.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can tweak this!

@mcmorisi mcmorisi requested a review from NoahStapp March 24, 2025 14:54
@mcmorisi mcmorisi merged commit bdc7b75 into mongodb:master Mar 24, 2025
6 checks passed
@mcmorisi mcmorisi deleted the DOCSP-48161-connect-async branch March 24, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants